Skip to content

Update Huawei VRP display lldp neighbor #2104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update Huawei VRP display lldp neighbor #2104

wants to merge 4 commits into from

Conversation

evilmonkey19
Copy link
Contributor

  • Changing from VLAN_1_NAME to VLAN_NAME
  • Adding new types

@mjbear mjbear added WIP Work in Progress breaking_change labels Apr 17, 2025
mjbear
mjbear reviewed Apr 18, 2025
View reviewed changes
tests/huawei_vrp/display_lldp_neighbor/huawei_vrp_display_lldp_neighbor.yml
Comment on lines -30 to +42
- "Cisco IOS Software, C2960S Software (C2960S-UNIVERSALK9-M), Version 12.2(55)SE7,\
\ RELEASE SOFTWARE (fc1)"
- "Cisco IOS Software, C2960S Software (C2960S-UNIVERSALK9-M), Version 12.2(55)SE7,
RELEASE SOFTWARE (fc1)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evilmonkey19
Are you certain this is correct?

When I run the cli.py helper to generate the structured data, it has the backslashes for all five yaml files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run it using the command the following command and I get the same output:

invoke gen-yaml-file <path>/ntc-templates/tests/huawei_vrp/display_lldp_neighbor/huawei_vrp_display_lldp_neighbor5.raw --local

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it is an issue with this gen-yaml-file command or the cli.py. Perhaps it is just something from changing line.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it is an issue with this gen-yaml-file command or the cli.py. Perhaps it is just something from changing line.

This re-surfaced when using cli.py ... hmmm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the output i get using directly TextFSM
FSM Table:
['LOCAL_INTERFACE', 'CHASSIS_TYPE', 'CHASSIS_ID', 'PORT_ID_TYPE', 'PORT_ID_SUBTYPE', 'MANUFACTURER', 'PLATFORM', 'NEIGHBOR_PORT_ID', 'NEIGHBOR_INTERFACE', 'NEIGHBOR_NAME', 'NEIGHBOR_DESCRIPTION', 'SYSTEM_CAPABILITIES_SUPPORTED', 'CAPABILITIES', 'MGMT_ADDRESS_TYPE', 'MGMT_ADDRESS', 'EXPIRED_TIME', 'VLAN_ID', 'VLAN_ID_AND_PROTOCOL', 'VLAN_NAME', 'SERIAL', 'OID', 'AUTONEGOTIATION_SUPPORTED', 'AUTONEGOTIATION_ENABLED', 'OPERATION_MODE', 'POWER_PORT_CLASS', 'PSE_POWER_PAIRSX', 'PSE_POWER_SUPPORTED', 'PSE_POWER_ENABLED', 'PSE_PAIRS_CONTROL_ABILITY', 'POWER_PAIRS', 'POWER_CLASS', 'POWER_CLASS_EXT', 'POWER_EXT_TYPE', 'PSE_ALLOCATED_MODE_POWER_A', 'PSE_ALLOCATED_MODE_POWER_B', 'PSE_POWERING_STATUS', 'PSE_AUTOCLASS_SUPPORT', 'PD_4PID', 'PD_LOAD', 'PD_POWERED_STATUS', 'DUAL_SIGNATURE_POWER_CLASSX_MODE_A', 'DUAL_SIGNATURE_POWER_CLASSX_MODE_B', 'AUTOCLASS_COMPLETED', 'AUTOCLASS_REQUEST', 'POWER_DOWN_REQUEST', 'POWER_DOWN_TIME', 'POWER_DOWN', 'POWER_CAPABILITY', 'POWER_UP_MODE', 'PORT_POWER_CLASSIFICATION', 'LINK_AGGREGATION_SUPPORTED', 'LINK_AGGREGATION_ENABLED', 'AGGREGATION_PORT_ID', 'PORT_IDENTITY', 'DISCOVERED_TIME', 'ENERGY_EFFICIENT_ETHERNET_SUPPORT', 'TRANSMIT_TW', 'RECEIVE_TW', 'FALLBACK_RECEIVE_TW', 'ECHO_TRANSMIT_TW', 'ECHO_RECEIVE_TW', 'NETWORK_CARD_ID', 'MAXIMUM_FRAME_SIZE', 'MED_CAPABILITY', 'MED_DEVICE_TYPE', 'MED_DEVICE_CLASS', 'FIRMWARE_REVISION', 'HARDWARE_REVISION', 'SOFTWARE_REVISION', 'SERIAL_NUMBER', 'MANUFACTURER_NAME', 'MODEL_NAME', 'ASSET_TRACKING_IDENTIFIER', 'MEDIA_POLICY_TYPE', 'UNKNOWN_POLICY', 'VLAN_TAGGED', 'MEDIA_POLICY_VLAN_ID', 'MEDIA_POLICY_L2_PRIORITY', 'MEDIA_POLICY_DSCP', 'POWER_TYPE', 'POWER_SOURCE', 'POWER_PRIORITY', 'PD_REQUESTED_POWER', 'PSE_ALLOCATED_POWER', 'PD_REQUESTED_POWER_MODE_A', 'PD_REQUESTED_POWER_MODE_B', 'PSE_MAXIMUM_AVAILABLE_POWER', 'PSE_POWER_PAIRS_EXT', 'POE_PSE_POWER_SOURCE', 'PORT_PSE_PRIORITY', 'PORT_AVAILABLE_POWER_VALUE', 'LOCATION_FORMAT', 'LOCATION_INFORMATION']
['GigabitEthernet0/0/1', 'macAddress', 'f55f-c2c5-e180', 'interfaceName', '', '', '', 'Gi1/0/1', 'GigabitEthernet1/0/1', 'tsa-2960-sw01', ['Cisco IOS Software, C2960S Software (C2960S-UNIVERSALK9-M), Version 12.2(55)SE7, RELEASE SOFTWARE (fc1)', 'Technical Support: http://www.cisco.com/techsupport', 'Copyright (c) 1986-2013 by Cisco Systems, Inc.', 'Compiled Mon 28-Jan-13 10:28 by prod_rel_team'], 'bridge router', 'bridge', '', '192.168.0.240', '102', '1', '', '', '', '', 'Yes', 'Yes', 'speed(1000)/duplex(Full)', 'PD', '', 'No', 'No', 'No', 'Unknown', '', '', '', '', '', '', '', '', '', '', '', '', '', '', '', '', '', '', '', 'Unknown', 'No', 'No', '0', '', '', '', '', '', '', '', '', '', '0', '', '', 'Network Connectivity', '', 'WS-C2960S-48LPS-L (PowerPC):F0', '12.2(55)SE7', '', 'Cisco Systems, Inc.', 'WS-C2960S-48LPS-L', '', 'Voice', 'Unknown', 'No', '0', '0', '0', 'PSE', '', '', '', '', '', '', '', '', 'PSE', 'Low', '0', 'Civic Address LCI', 'what(LLDP-MED Endpoint) country( )']
['GigabitEthernet0/0/8', 'macAddress', 'f41f-c2c5-e180', 'interfaceName', '', '', '', 'Gi1/0/2', 'GigabitEthernet1/0/2', 'tsa-2960-sw01', ['Cisco IOS Software, C2960S Software (C2960S-UNIVERSALK9-M), Version 12.2(55)SE7, RELEASE SOFTWARE (fc1)', 'Technical Support: http://www.cisco.com/techsupport', 'Copyright (c) 1986-2013 by Cisco Systems, Inc.', 'Compiled Mon 28-Jan-13 10:28 by prod_rel_team'], 'bridge router', 'bridge', '', '192.168.0.241', '102', '1', '', '', '', '', 'Yes', 'Yes', 'speed(1000)/duplex(Full)', 'PD', '', 'No', 'No', 'No', 'Unknown', '', '', '', '', '', '', '', '', '', '', '', '', '', '', '', '', '', '', '', 'Unknown', 'No', 'No', '0', '', '', '', '', '', '', '', '', '', '0', '', '', 'Network Connectivity', '', 'WS-C2960S-48LPS-L (PowerPC):F0', '12.2(55)SE7', '', 'Cisco Systems, Inc.', 'WS-C2960S-48LPS-L', '', 'Voice', 'Unknown', 'No', '0', '0', '0', 'PSE', '', '', '', '', '', '', '', '', 'PSE', 'Low', '0', 'Civic Address LCI', 'what(LLDP-MED Endpoint) country( )']

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry but perhaps it is but i don't see the issue 😅. Why this should be a problem?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry but perhaps it is but i don't see the issue 😅. Why this should be a problem?

It's perplexing that the back slashes end up back in there when I regenerate output. I'd like to discover why. 😖

This is so I can prevent myself from possibly causing unwanted/unnecessary modification of the test data (in any case that I end up regenerating structured YAML output in the future).

I'm not intending to make this something you (@evilmonkey19) have to solve or anything like that. ☺️

@mjbear mjbear changed the title Updating template Huawei VRP: display lldp neighbor Update Huawei VRP display lldp neighbor Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjbear mjbear mjbear left review comments

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks itdependsnetworks is a code owner

@jmcgill298 jmcgill298 Awaiting requested review from jmcgill298 jmcgill298 is a code owner

@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
breaking_change WIP Work in Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evilmonkey19 @mjbear