Add Linux iwconfig #2122
Add Linux iwconfig #2122
Conversation
evilmonkey19
requested review from
itdependsnetworks,
jmcgill298,
jvanderaa and
mjbear
as code owners
Further define the recording regex beginning with "wl" so it is less likely to inadvertently match other text. Examples it will match: - wlan0 - wlp3s0
| ^\s*${INTERFACE}\s+no\s*wireless\s*extensions\.$$ -> Clear | ||
| ^\s*${INTERFACE}\s+(IEEE\s+802\.11\w*|unassociated)(?:\s+ESSID:off\/any)?(?:\s+Nickname:\"${NICKNAME}\")?\s*$$ | ||
| ^\s*${INTERFACE}\s+(IEEE\s+802\.11\w*|unassociated)(?:\s+ESSID:\"${ESSID}\"\s+)?(?:\s*Nickname:\"${NICKNAME}\")?\s*$$ | ||
| ^\s*${INTERFACE}\s+IEEE\s+802\.11\s+Mode:\s*${MODE}\s*Frequency:\s*${FREQUENCY}\s+Tx-Power=${TX_POWER}\s*$$ |
There was a problem hiding this comment.
@evilmonkey19 Would you be able to provide test data that covers this 802.11 Mode: regex?
There was a problem hiding this comment.
@evilmonkey19 Would you be able to provide test data that covers this
802.11 Mode:regex?
Hello @evilmonkey19, by chance did you see this question?
Thank you!
| wlan3 unassociated Nickname:"<WIFI@REALTEK>" | ||
| Mode:Managed Frequency=5.18 GHz Access Point: Not-Associated |
There was a problem hiding this comment.
Frequency=5.18 GHz
Was this equal sign = instead of colon : an accidental modification?
(None of the other frequency labels are like this.)
Swap \s+ for \s* where there is at least one space. Doing so for flexibility reasons.
Since none of the labels have a space before the colon it doesn't seem necessary to have the extra characters.
| eth0 no wireless extensions. | ||
|
|
||
| wlan0 IEEE 802.11 ESSID:"My_home" | ||
| Mode:Managed Frequency:5.18 GHz Access Point: AA:AA:AA:AA:AA:AA |
There was a problem hiding this comment.
The only "label" that has a space after the colon (or equal sign) separator is Access Point.
-
Do we have test data that supports the existence of spaces after the colon/equals?
-
Should we remove some of those fluff whitespace regexes?
New template.