-
Notifications
You must be signed in to change notification settings - Fork 760
Add Huawei VRP display license verbose #2127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Huawei VRP display license verbose #2127
Conversation
@brian-s-cao
Would it make sense to cascade the license and product data into later dictionaries? So the license and product info would be present in product and feature/sale dictionaries. Or possibly we create different states to organize the output a bit -- the several If you're welcome to suggestions, I'll work something up in a branch so we can visualize it. |
Hi @mjbear, Thanks for the thoughtful suggestions! Yes, the current TextFSM template produces a flat dictionary structure, and I agree it would be more organized to cascade the I'm definitely open to your idea of reorganizing the output with distinct states or nested dictionaries. Thanks again! |
😀 You're welcome.
Ironically I worked up the state transitions first and realized this isn't quite complex enough to benefit much. Basically a couple of lines had to be duplicated so it didn't make sense for two additional States. That was a bit of work ... just to figure out we wouldn't use it, heh. @brian-s-cao If you approve and merge my PR into your branch then will show up on this PR. Cool stuff, eh? haha A pretty big takeaway is the 5->3 dictionary reduction!
😁 👍 (While not obligated, there's a buymeacoffee link on my profile if you want to fuel me up, haha.) |
Enhance and reduce resulting dict count
@mjbear The 5-to-3 dictionary reduction definitely makes the structure cleaner and easier to work with. Really appreciate the effort and thought you put into this. I saw your BuyMeACoffee link — unfortunately, I don’t have access to international payment methods at the moment. But if you happen to use WeChat Pay or Alipay, I’d be happy to support you that way instead. Thanks again! |
No description provided.