-
Notifications
You must be signed in to change notification settings - Fork 760
Cisco IOS-XE additional transceiver data (CURRENT) #2129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Multi stack show power inline processing
… the record data, or will be blank value for legacy IOS output.
ntc_templates/templates/cisco_ios_show_interface_transceiver.textfsm
Outdated
Show resolved
Hide resolved
ntc_templates/templates/cisco_ios_show_interface_transceiver.textfsm
Outdated
Show resolved
Hide resolved
…extfsm Co-authored-by: Michael Bear <[email protected]>
ntc_templates/templates/cisco_ios_show_interface_transceiver.textfsm
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the message output from the networking device would be string literals, I feel like matching (a space) with regex adds unnecessary ambiguity.
I can see where you're coming from. While not an absolute, there's a general consensus going back years to flexibly match white space so the possibility of breakage on vendor white space changes is minimized. This minimizes the possibility for issues and maintenance on the templates (or at least that's the hope! For those couple error messages, tucking I'd like to leave this up for discussion so some templating veterans can comment here. Thank you for the contributions and discussion @paineta! |
No problem. Thanks. |
Existing template did not properly parse the additional "current" value in the "show interface transceiver" output on Cisco IOS-XE. I added support to collect the Current value or leave it blank, as to not break legacy output, and I also fleshed out the template to include an Error directive.