Skip to content

Fix for Device lines in huawei_vrp lldp neighbors #2226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmcgill298 merged 2 commits into from
Nov 11, 2025
Merged

Fix for Device lines in huawei_vrp lldp neighbors #2226

jmcgill298 merged 2 commits into from
Nov 11, 2025

Conversation

@mjbear
Copy link
Collaborator

@mjbear mjbear commented Nov 1, 2025 •
edited
Loading

resolves #2204

  • Add "Device" lines so parsing doesn't reach the Error directive.
  • Huawei devs misspelled 'information' so I made the 'r' optional in the regex
  • Fix parsing when interfaces are named something other than GigabitEthernet/GE
    • From the test data, 10GE is XGigabitEthernet so faster ports didn't match the existing regex

@mjbear mjbear added the WIP Work in Progress label Nov 1, 2025
@mjbear mjbear marked this pull request as ready for review November 1, 2025 19:17
@mjbear mjbear removed the WIP Work in Progress label Nov 1, 2025
@mjbear mjbear mentioned this pull request Nov 1, 2025
Closed
@jmcgill298 jmcgill298 merged commit 638a9f7 into networktocode:master Nov 11, 2025
10 checks passed
@mjbear mjbear deleted the huawei_vrp_lldp_neigh_issue2204 branch November 12, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmcgill298 jmcgill298 jmcgill298 approved these changes

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks itdependsnetworks is a code owner

@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Neighbor block in "display lldp neighbor" of huawei_vrp sometimes have unexpected data

2 participants

@mjbear @jmcgill298