fix(hp_procurve): add VSF stacking support to show system template #2282#2283
Open
molhamalnasr wants to merge 3 commits intonetworktocode:masterfrom
Open
fix(hp_procurve): add VSF stacking support to show system template #2282#2283molhamalnasr wants to merge 3 commits intonetworktocode:masterfrom
molhamalnasr wants to merge 3 commits intonetworktocode:masterfrom
Conversation
…etworktocode#2282) The hp_procurve_show_system template fails to parse output from switches running in VSF (Virtual Switching Framework) mode. In VSF mode, the output splits into per-member sections with a different field layout than standalone switches. Changes: - Add Filldown to shared fields (NAME, CONTACT, LOCATION, etc.) - Add MEMBER_ID value to identify VSF members - Add split-line matching for Software revision and Base MAC Addr - Add VSF state to capture per-member fields (ROM, serial, MAC, etc.) - Add Required on ROM_VERSION to filter empty EOF records - Add VSF test data with 2-member stack output - Update existing standalone test data with new member_id field Fixes networktocode#2282
molhamalnasr
requested review from
itdependsnetworks,
jmcgill298,
jvanderaa,
matt852 and
mjbear
as code owners
Consolidate/simplify since there isn't an operational advantage to the extra state.
Collaborator
|
Good work @molhamalnasr. I'm on the fence whether it's worth replacing the single literal spaces with a white space regex Let us know your thoughts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hp_procurve_show_system template fails to parse output from switches running in VSF (Virtual Switching Framework) mode. In VSF mode, the output splits into per-member sections with a different field layout than standalone switches.
Changes:
Fixes #2282