Skip to content

FTY remerge as of 20250415 with NUT tag v2.8.3-rc4 and 20250421 with tag v2.8.3-rc5 #2903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 83 commits into
base: FTY
Choose a base branch
from

Conversation

jimklimov
Copy link
Member

Follow-up to #2875 to verify new RC still behaves nice

jimklimov and others added 30 commits April 11, 2025 15:05
…tderr if calling upssched and NUT_DEBUG_LEVEL>0 [networkupstools#2890]

Signed-off-by: Jim Klimov <[email protected]>
Negative floats, and floats 0.08/0.09 were resulting in invalid octal
numbers.

The envoy API occasionally stalls; extended timeout to 10s and
added a single retry to avoid spurious "nocomms" state.

Signed-off-by: Scott Shambarger <[email protected]>
…r non-disruptive tests" chapter title and references (Unicode=>ASCII)

Signed-off-by: Jim Klimov <[email protected]>
…d FS layout to existing deployment to be overwritten

Signed-off-by: Jim Klimov <[email protected]>
…lip library version-info to new "current" numbers (more symbols exported now) [networkupstools#2895]

Signed-off-by: Jim Klimov <[email protected]>
…er also cgipath, drvpath, datadir, libdir [networkupstools#2895]

Signed-off-by: Jim Klimov <[email protected]>
…ild routine too instead of "make check"

Signed-off-by: Jim Klimov <[email protected]>
desertwitch and others added 13 commits April 18, 2025 17:25
…uce upsmon OVERDURATION setting

Signed-off-by: desertwitch <[email protected]>
…uce upsmon ALARMCRITICAL setting

Signed-off-by: desertwitch <[email protected]>
…(generate sources via nut-scanner-deps/tools only once) [networkupstools#2825]

Signed-off-by: Jim Klimov <[email protected]>
@teoberi
Copy link

teoberi commented Apr 18, 2025

Why does NUT CI farm - Jenkins checks take so long a day and almost 9 hours so far in this case?

…writer/expectations with documentation [networkupstools#2909]

Signed-off-by: desertwitch <[email protected]>
@jimklimov
Copy link
Member Author

jimklimov commented Apr 19, 2025

It runs a matrix of several thousand builds with different dependencies and build settings, varied toolkits, compiler versions, distro releases, etc. Quite often just one combo acts up, so quality-wise across the big board this is worth it.

The builds also compete for computers involved, so most of the time scenarios wait in a queue. Currently there are also pre-release "fightwarn" builds with more warnings enabled to check for surprises and running on more obscure platforms (some in QEMU, which also impacts the speed those matrix cells get completed).

The DMF code base also involves more work with generated mapping tables and checking them, so it is a bit of an outlier until it would get merged; a single (non-competing) set of scenarios for a master branch completes in 5-7 hours with no delays due to other jobs.

@teoberi
Copy link

teoberi commented Apr 20, 2025

It took 2 days and a few dozen minutes to check each of the 3 Pull requests left open in the case of NUT 2.8.3.
It seems a bit long to me, but I hope the wait is over.

@jimklimov
Copy link
Member Author

Well... the architecture is open to people providing their hardware as workers for the NUT CI farm, although the original intent was to register unique workers (like when someone cares for NUT on AIX or HPUX, and has a machine, it could be made available as a swarm agent and dynamatrix cells to test for its toolkits would get generated). So far it is mostly VMs of various linux/bsd/illumos/... systems, some hosted on DigitalOcean donated resources. My home is also heated by one of such machines.

@jimklimov
Copy link
Member Author

That said, a long-standing technical debt around this does exist - to revise the scenario definitions (see Jenkinsfile-dynamatrix and the dynamically generated build matrix summary stored as an artifact with each build), I suspect a certain amount of build scenarios could end up doing duplicated effort needlessly: e.g. it suffices to generate docs once per platform and I am not sure extra generations do not happen (with distcheck or explicitly); maybe some combos of toolkit/language spec/OS/CPU/... pop up independently due to different queries...

It could be beneficial to pore over the list of combos (or teach an AI to do so), and possibly separate them into even more fine-grained definitions (there are already about 20 groups of rules) if any systemic overlaps are identified. Or to find some patterns about this and code better de-duplication in https://github.com/networkupstools/jenkins-dynamatrix where the run-time matrix gets generated based on each build's circumstances (such as the currently seen population of build agents' announced capabilities).

The first step is to indeed pore over those logs to see if the suspicion about undesired duplicates is valid or not. Maybe there is no problem to solve here after all, and all scenarios are unique. This is something I can't bring myself to do, it seems - more urgent priorities take over and this remains a way to train patience..

…twarn/qemu scenarios)

At least now that the worker available to NUT CI farm requires hacks for HomeBrew
with -Wno-poison-system-directories ...

Signed-off-by: Jim Klimov <[email protected]>
Clarify message for `nutdrv_qx` mismatch of `port!="auto"` and presence of USB settings
…uration

upsmon: introduce OVERDURATION for OVER+NOCOMM states
RC5: report libmodbus linking type in drivers with it; revise NEWS and UPGRADING docs for 2.8.3; manage upsmon overload notifications and criticality; revise some messages from CLI tools
Release NUT v2.8.3-rc5

Signed-off-by: Jim Klimov <[email protected]>
@jimklimov jimklimov changed the title FTY remerge as of 20250415 with NUT tag v2.8.3-rc4 FTY remerge as of 20250415 with NUT tag v2.8.3-rc4 and 20250421 with tag v2.8.3-rc5 Apr 21, 2025
@teoberi
Copy link

teoberi commented Apr 21, 2025

It works! It works!
The only thing that still bothers me is the -rc5 suffix!
PS
I disabled support for SSL and USB drivers (which I don't need) and it actually works, including the messages displayed in the console, now nothing scares me anymore!

@jimklimov
Copy link
Member Author

Note that many of the messages (like NUT version banners, SSL not-init, etc.) can now also be silenced with environment variables, commonly exported by an init-script, systemd unit, your shell profile (for CLI commands), etc. - see nut.conf.sample comments for an overview.

@teoberi
Copy link

teoberi commented Apr 21, 2025

I know, you told me that and I already did it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DMF NUT Data/Dynamic Mapping File/Format/Functionality feature refactor/fightwarn PR or issue proposal to improve code maintainability without functional changes, or to fix warnings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants