-
-
Notifications
You must be signed in to change notification settings - Fork 373
Report libmodbus linking type in drivers with it; revise NEWS and UPGRADING docs for 2.8.3 #2904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jimklimov
wants to merge
14
commits into
networkupstools:master
Choose a base branch
from
jimklimov:pre-283-5
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+331
−234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jimklimov
commented
Apr 16, 2025
- The driver changes are an aid to troubleshoot Build a driver from source for an existing installation: apc_modbus + USB #2897 and APC_MODBUS _apc_modbus_read_registers Timeouts #2609.
- Also quiesce by default the message about lack of notification tech if the first (likely only) place we show it is when stopping the NUT program (probably a daemon-capable one), like a driver with failed configuration. The message more distracts from troubleshooting than helps in the field. Follows-up for Build a driver from source for an existing installation: apc_modbus + USB #2897 and On systemd aware OSes, optionally integrate with sd_notify() #1590.
- Docs are generally tidying up for the upcoming release.
…irst message to be suppressed is already about stopping the program [networkupstools#1590] Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
…_libmodbus also Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
…awei-ups2000.c, drivers/socomec_jbus.c, drivers/adelsystem_cbi.c: report NUT_MODBUS_LINKTYPE_STR Signed-off-by: Jim Klimov <[email protected]>
…upstools#2897] Signed-off-by: Jim Klimov <[email protected]>
…nd to upper-case starts of sentences Signed-off-by: Jim Klimov <[email protected]>
…rts of sentences Signed-off-by: Jim Klimov <[email protected]>
…AB chars Signed-off-by: Jim Klimov <[email protected]>
…separated by TAB chars) Signed-off-by: Jim Klimov <[email protected]>
…(generate sources via nut-scanner-deps/tools only once) [networkupstools#2825] Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
…fore release Signed-off-by: Jim Klimov <[email protected]>
✅ Build nut 2.8.3.3018-master completed (commit 27734eeeac by @jimklimov) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI
Entries related to continuous integration infrastructure (historically also recipes like Makefiles)
documentation
modbus
packaging
portability
We want NUT to build and run everywhere possible
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.