Move inet_ntopXX() methods to common.{c,h}
#2916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kupstools#2915] Signed-off-by: Jim Klimov <[email protected]>
…fo conversion [networkupstools#2915] Signed-off-by: Jim Klimov <[email protected]>
…2915] Signed-off-by: Jim Klimov <[email protected]>
…psclient and upsd Signed-off-by: Jim Klimov <[email protected]>
jimklimov
added
enhancement
C-str
…normally Avoid firing up QEMU builders on the NUT CI farm, unless we want QEMU tests Signed-off-by: Jim Klimov <[email protected]>
jimklimov
added
the
CI
Signed-off-by: Jim Klimov <[email protected]>
…s with NUT_WANT_INET_NTOP_XX macro [networkupstools#2916] Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
jimklimov
added
impacts-release-2.8.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a fair amount of ritual to
memcpy()(for alignment) the socket structures for different address families, to extract the IP (or other) address from them withinet_ntop()afterwards. Relocating these methods into one spot allows to simplify repetitions of that code in NUT codebase, as well as commonly extend later (e.g.AF_UNIX?..) should we want to.Follows up from #2915 (includes it) and #2847.
The problem seems to have been introduced in #2012 (part of NUT v2.8.2).