Skip to content

List all repos; Add stale and new criteria#2

Merged
jtviolet merged 4 commits into
mainfrom
bowers-repo-list-updates
Feb 10, 2026
Merged

List all repos; Add stale and new criteria#2
jtviolet merged 4 commits into
mainfrom
bowers-repo-list-updates

Conversation

@marty-bowers-netwrix
Copy link
Copy Markdown
Contributor

One change:

  • List all repos rather than just those with one or more criteria in the list

Two additions:

  • Add indicator for stale repos
  • Add indicator for new repos

@jtviolet
Copy link
Copy Markdown
Collaborator

@claude the test failed. Do new tests need to be added to support these new data points?

@claude
Copy link
Copy Markdown

claude Bot commented Feb 10, 2026

Claude finished @jtviolet's task in 2m 55s —— View job


Test fixes completed ✅

  • Check CI status to see what tests failed
  • Read repository guidelines (CLAUDE.md)
  • Review the changed files to understand new features
  • Examine existing tests
  • Identify missing test coverage
  • Add/update tests as needed
  • Run tests to verify fixes
  • Commit and push changes

Analysis:

The PR changed the behavior to list all repos in the details table (not just those with features). Three existing tests expected the old behavior where repos without features were excluded.

Changes made to tests/test_renderer.py:

  1. Line 70: Updated test_details_section to expect repo-d to appear (even though it has no features)
  2. Line 172: Renamed test_detail_table_only_shows_repos_with_featurestest_detail_table_shows_all_repos and updated to expect all repos
  3. Line 325: Updated test_details_section_with_only_inactive_repos to expect the table to still appear
  4. Line 170: Updated test_detail_table_has_correct_columns to include "New" and "Stale" columns in the header
  5. Line 212: Added new test test_detail_table_new_and_stale_indicators to verify 🆕 and ⚠️ indicators

Summary:

The tests have been updated to align with the new behavior where all repos are listed in the details table regardless of whether they have features. The new "New" and "Stale" columns are now properly tested. The changes have been committed and pushed to the bowers-repo-list-updates branch.

CI will run the tests again to verify everything passes.

--- | Branch: bowers-repo-list-updates

- Update test_details_section to expect repos without features
- Rename and update test_detail_table_only_shows_repos_with_features to test_detail_table_shows_all_repos
- Update test_details_section_with_only_inactive_repos to expect table output
- Update test_detail_table_has_correct_columns to include New and Stale columns
- Add test_detail_table_new_and_stale_indicators to verify new indicators

Co-authored-by: Jordan Violet <jtviolet@users.noreply.github.com>
@jtviolet
Copy link
Copy Markdown
Collaborator

Investigating test failure

  • Check CI status to see what tests failed
  • Read repository guidelines (CLAUDE.md)
  • Review the changed files to understand new features
  • Examine existing tests
  • Identify missing test coverage
  • Add/update tests as needed
  • Run tests to verify fixes
  • Commit and push changes

Analysis:

The PR changes the behavior to list all repos in the details table (not just those with features). This is indicated by line 72 in src/renderer.py:

active_repos = stats.repos  # Was previously filtered to repos with features

However, 3 existing tests expect the old behavior where empty repos are excluded:

  1. test_details_section - expects repo-d (no features) to not appear
  2. test_detail_table_only_shows_repos_with_features - explicitly tests that empty repos are excluded
  3. test_details_section_with_only_inactive_repos - expects empty output when all repos have no features

The tests also need to account for the new "New" and "Stale" columns that were added to the details table.

Good news: The new is_stale and is_new fields are already being tested in test_models.py (lines 126-148), so those tests passed.

View job run

@claude write the necessary tests for the new features and submit a PR.

@claude
Copy link
Copy Markdown

claude Bot commented Feb 10, 2026

Claude finished @jtviolet's task in 48s —— View job


Test coverage analysis complete ✅

  • Check current git status and recent commits
  • Review CI status for the PR
  • Verify test coverage for new features
  • Determine if additional work is needed

Summary

Good news! The tests have already been written and are passing. The previous Claude run (visible in the comment history above) successfully updated all necessary tests to support the new features.

What was already completed:

  1. Test updates for "list all repos" behavior (tests/test_renderer.py):

    • Line 70: Updated test_details_section to expect all repos including repo-d
    • Line 172: Renamed and updated test_detail_table_only_shows_repos_with_featurestest_detail_table_shows_all_repos
    • Line 325: Updated test_details_section_with_only_inactive_repos to expect table even with empty repos
  2. Test coverage for new "New" and "Stale" columns (tests/test_renderer.py):

    • Line 170: Updated header test to include "New" and "Stale" columns
    • Line 212: Added new test test_detail_table_new_and_stale_indicators verifying 🆕 and ⚠️ indicators appear correctly
  3. Model-level tests for new fields (tests/test_models.py):

    • Lines 126-148: Tests for is_stale and is_new aggregation already existed and passed

Current status:

CI Status: ✅ All tests passing

  • CI workflow: ✅ Success
  • PR workflow: ✅ Success

Test Coverage: ✅ Complete

  • All new features have corresponding tests
  • Both unit tests (models) and integration tests (renderer) are in place
  • Tests verify correct behavior of stale/new indicators and "list all repos" functionality

No additional work needed - the PR is ready for review and merge.


| Branch: bowers-repo-list-updates

The Claude Code and Claude Code Review workflows had read-only
permissions, preventing them from posting review comments and
PR comments. Update to write permissions where needed.
Comment thread .github/workflows/claude-code-review.yml Fixed
Comment thread .github/workflows/claude.yml Fixed
@jtviolet jtviolet merged commit c91b493 into main Feb 10, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants