fix(web): prevent mixed content by using relative nginx redirects#418
Merged
fix(web): prevent mixed content by using relative nginx redirects#418
Conversation
- Gracefully handle getUserShares failures by returning empty result - Add retry logic with cooldown to prevent infinite filter fetch loops - Add remotion build output to gitignore
Add `absolute_redirect off` to nginx config so directory redirects (e.g. /imagine -> /imagine/) use relative URLs instead of absolute http:// URLs, which get blocked as mixed content on HTTPS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
absolute_redirect off;to the nginx server block in the web Dockerfile/imaginewhere nginx's directory redirect usedhttp://instead of relative URLs/imagineroute has a real directory (apps/web/public/imagine/) containing preview images, causing nginx to issue a 301 redirect from/imagineto/imagine/using an absolutehttp://URL — which gets blocked on HTTPSTest plan
https://beta.gruenerator.de/imagineand confirm no mixed content warning in DevTools console/imagineroute still loads correctly (SPA fallback to index.html)