Skip to content

fix: resolve eslint errors, warnings, and error handling improvements#420

Merged
Movm merged 1 commit intomasterfrom
fix/eslint-lint-errors
Jan 29, 2026
Merged

fix: resolve eslint errors, warnings, and error handling improvements#420
Movm merged 1 commit intomasterfrom
fix/eslint-lint-errors

Conversation

@Movm
Copy link
Copy Markdown
Collaborator

@Movm Movm commented Jan 29, 2026

Summary

  • ESLint errors fixed: Type-only imports (IMessage, ImageSourcePropType), conditional React hooks moved before early returns, require() replaced with ES module imports, let changed to const for non-reassigned variable
  • ESLint warnings fixed: Replaced disallowed console.info with console.warn, added void for unhandled promise, suppressed react/no-array-index-key where items lack stable IDs
  • Error handling: Added error handling for share queries, filtered fetch retries, and prevented mixed content via relative nginx redirects

Test plan

  • Verify CI quality checks pass (eslint, typecheck)
  • Confirm mobile app login screen renders correctly with imported image assets
  • Confirm image studio editor and edit chat modals work without hook order issues
  • Verify sites app components render lists correctly

- Use type-only imports for IMessage and ImageSourcePropType
- Replace require() with ES module imports for image assets
- Move useCallback/useSafeAreaInsets hooks before early returns
- Change let to const for non-reassigned variable
- Replace disallowed console.info with console.warn
- Use explicit if/else for console methods to satisfy no-console rule
- Add void operator for unhandled Linking.openURL promise
- Suppress array-index-key warnings where items lack stable IDs
@Movm Movm merged commit 579b052 into master Jan 29, 2026
9 of 10 checks passed
@Movm Movm deleted the fix/eslint-lint-errors branch March 10, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant