fix(web): rename public/imagine to prevent mixed content on /imagine route#421
Merged
fix(web): rename public/imagine to prevent mixed content on /imagine route#421
Conversation
…ixed content The /imagine route collided with the public/imagine/ directory, causing nginx to issue a 301 redirect using http:// (mixed content). Renaming the static assets directory eliminates the collision so nginx falls through to the SPA fallback. Also reverts the absolute_redirect off workaround as it's no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/web/public/imagine/→apps/web/public/imagine-assets/to eliminate a collision between the SPA route/imagineand the static assets directory, which caused nginx to issue a mixed-content 301 redirect/imagine/…→/imagine-assets/…) across 16 source files, leaving API endpoint routes (/imagine/pure) unchangedabsolute_redirect off;nginx workaround from the Dockerfile since it's no longer neededTest plan
https://beta.gruenerator.de/imagineloads without mixed content errors/imagine-assets/…)/imagine/pureendpoint) still works