fix(web): add loading state and per-subtype display to UniversalTab#426
Merged
fix(web): add loading state and per-subtype display to UniversalTab#426
Conversation
The UniversalTab (Sonstige) had two bugs:
- No loading spinner because loading prop was never
passed to BaseForm
- Display section didn't update when switching sub-types
because all shared a single store key
Add isLoading state with try/finally in handleSubmit
and pass it to BaseForm. Use per-subtype componentName
(e.g. universal-text-rede) so each sub-type gets its
own storage slot. Remove key={selectedType} forced
remount. Update hasGeneratedContent in TexteGenerator
to also check sub-type keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isLoadingstate toUniversalTabwithtry/finallyinhandleSubmit, and passloading={isLoading}toBaseFormso the submit button spinner workscomponentNamefrom static'universal-text'to dynamicuniversal-text-${selectedType}so each sub-type (Rede, Wahlprogramm, etc.) gets its own slot in the generated text store — display section now correctly shows/hides content when switching sub-typeskey={selectedType}onBaseFormsince distinctcomponentNamevalues handle isolation naturallyTexteGeneratorto also look at per-subtype keys so the layout detects content from any universal sub-typeTest plan