chore: sync master to test-branch for testing#428
Merged
Movm merged 7 commits intotest-branchfrom Jan 29, 2026
Merged
Conversation
The UniversalTab (Sonstige) had two bugs:
- No loading spinner because loading prop was never
passed to BaseForm
- Display section didn't update when switching sub-types
because all shared a single store key
Add isLoading state with try/finally in handleSubmit
and pass it to BaseForm. Use per-subtype componentName
(e.g. universal-text-rede) so each sub-type gets its
own storage slot. Remove key={selectedType} forced
remount. Update hasGeneratedContent in TexteGenerator
to also check sub-type keys.
…-and-display fix(web): add loading state and per-subtype display to UniversalTab
- Inject profile.custom_prompt as fallback in PromptProcessor pipeline - Remove old per-generator fields (antragPrompt, socialPrompt, antragGliederung) from API, web, and mobile - Simplify instructions-status endpoint to check only custom_prompt - Delete dead InstructionsGrid and GroupInstructionsSection components - Keep presseabbinder and database columns unchanged
Remove the fallback guard so custom_prompt is always included when set in the user profile, regardless of whether the frontend also sends a customPrompt value.
Drop the 6 legacy per-generator custom prompt columns (custom_antrag_prompt, custom_social_prompt, custom_universal_prompt, custom_gruenejugend_prompt, custom_rede_prompt, custom_buergeranfragen_prompt) from schema.sql and local_setup.sql. Add SQL migration that merges existing per-type prompt data into the unified custom_prompt field with section labels before dropping columns. Add UI hint in profile view informing users their old Anweisungen were migrated into the personal prompt field. Remove useUserInstructions hook and all per-generator prompt references from form components.
…ontend plumbing Backend now always injects profile.custom_prompt into every request, making the frontend instructions-status check, store fields, and knowledgeFormUtils all redundant. Also decouples source.type from document clearing so documents remain independent of instruction state.
…rompt-cleanup refactor: unify custom_prompt and remove Anweisungen frontend plumbing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan