fix(chat): prevent false clarification on follow-ups + docs improvements#528
Merged
fix(chat): prevent false clarification on follow-ups + docs improvements#528
Conversation
EditorPage fired the document fetch before auth status resolved, causing authenticated users to hit the public endpoint (which 404s for private documents). Wait for isAuthLoading to be false before enabling the query.
Add two new templates to the document template picker: - Checkliste: tick list using BlockNote checkListItem blocks - Einladung: formal meeting invitation for Ortsvorstand sessions
…t export Add a cloud save button to the document editor that lets users save documents as DOCX to their Nextcloud (Wolke) share links. Includes a folder browser modal for choosing the target directory. Also extracts blockNoteXmlToHtml to a shared hocuspocus module and wires it into the export controller for proper HTML/Markdown/text export.
Restructure classifier Step 8 prompt so needsClarification: false is the default. Clarification is now the explicit AUSNAHME, triggered only when ALL conditions are met: no conversation history, no recognizable topic, and no way to answer without one. When conversation history exists, the classifier always sets needsClarification: false and trusts the downstream respondNode which has access to the full untruncated conversation.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Fix CodeQL polynomial regex (ReDoS) in blockNoteXmlToHtml.ts by splitting open/close tag regexes to remove ambiguous `\/?` alternation - Fix React Compiler lint errors in mobile app: - Move ref sync to useEffect in useMobileChatRuntime (react-hooks/refs) - Use null-check pattern for init-once ref in MobileChatProvider - Suppress Reanimated/expo-video immutability false positives - Fix useReelProcessing useCallback deps (user vs user?.id) - Suppress setState-in-effect for batch reset patterns - Suppress preserve-manual-memoization for stable ref identity - Prefix unused initialMessages param with underscore
CodeQL flags [^>]* as polynomial on input with repeated <blockGroup without closing >. Excluding < from the character class prevents the regex from consuming across tag boundaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
needsClarification: falseis the default. Clarification is now the explicit exception (AUSNAHME), only triggered when ALL conditions are met: no conversation history, no topic, can't answer without one. Fixes follow-up messages like "jetzt darauf basierend einen tweet" falsely triggering clarification buttons.blockNoteXmlToHtml.tsby splitting regexTest plan