FIX correct the invoke of oblique trees by feature combinations#347
Open
mamamum wants to merge 5 commits intoneurodata:mainfrom
Open
FIX correct the invoke of oblique trees by feature combinations#347mamamum wants to merge 5 commits intoneurodata:mainfrom
mamamum wants to merge 5 commits intoneurodata:mainfrom
Conversation
PSSF23
requested changes
Feb 20, 2025
Member
PSSF23
left a comment
PSSF23
left a comment
There was a problem hiding this comment.
You can put default hyperparameter in the init function instead of setting it specifically. Just make it feature_combinatinos=1 instead of None.
PSSF23
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
args feature_combinations in multiview tree is not in useWhat does this implement/fix? Explain your changes.
Now feature_combinations can be correctly given to feature_combinations_, if input feature_combinations is None, it will be defaultly set 1, which means not using oblique method
Any other comments?