Add missing data and trial logs #75
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for compliance with harp data logging conventions where all data files are split only by register address.
|
Test with the https://github.com/neurogears/ranson-rig/tree/missing-logs branch has produced no .bin logging files: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few logs were missing from the dataset and/or were being saved with inconsistent naming. Specifically, the current VR corridor position was not being logged with trial frame updates, and Harp logs were split between commands and events which does not conform to the current logging standard.
Here we introduce changes to make the naming consistent, refactor the trial data logging strategy to mirror consistent frame time logging from BonVision, and introduce a new global subject to store and log the current corridor position, if available.
Fixes #71
Fixes #51