Skip to content

v1.0.7 - Improve dependency install speed + more #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

HDash
Copy link
Member

@HDash HDash commented Mar 12, 2025

Key Changes

  • Add new input: ncpus
    • Use ncpus for R package installation
  • Document CODECOV_TOKEN
  • Update to actions/cache@v4 (v3 is marked for deprecation)
  • Add contributor details (me :) )

Saving for future PR: Issue #121 , would need lots of testing before release

Allows installation of binaries instead of source-only
@HDash HDash self-assigned this Mar 12, 2025
As v3 is marked for deprecation
@HDash HDash changed the title Improve dependency install speed Improve dependency install speed + more Mar 17, 2025
@HDash HDash changed the title Improve dependency install speed + more v1.0.7 - Improve dependency install speed + more Mar 18, 2025
@HDash HDash requested a review from Copilot April 7, 2025 15:09
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 11 changed files in this pull request and generated 1 comment.

Files not reviewed (4)
  • DESCRIPTION: Language not supported
  • README.Rmd: Language not supported
  • tests/testthat/test-get_authors.R: Language not supported
  • vignettes/rworkflows.Rmd: Language not supported

Fix typo

Co-authored-by: Copilot <[email protected]>
@HDash HDash requested a review from bschilder April 7, 2025 15:13
Delete temporary workflow used for testing the branch with different versions of Bioc Docker images
@HDash HDash marked this pull request as ready for review April 7, 2025 15:15
@bschilder
Copy link
Collaborator

These changes look great, thanks @HDash !

Only other thing I'd ask for is to update the use_workflow R function to include several the arguments:

use_workflow <- function(## action-level args

(arg in yaml --> arg in R function)

  • ncpus --> ncpus
  • CODECOV_TOKEN --> codecov_token

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants