Skip to content

[Performance] Using Echarts To Improve Raw Graph Performance #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: graph_performance
Choose a base branch
from

Conversation

ahmedtarek-
Copy link
Collaborator

WIP

@ahmedtarek-
Copy link
Collaborator Author

ahmedtarek- commented May 21, 2025

screen-capture.webm
I could only make it work, after being stuck for some time trying to make it work with subscription logic, as shown in the video.
It looks ugly af at the moment. On the bright side, the performance seems to be better and not lagging behind (the video is taken after running it for more than 2 minutes already).

My current task is to

  1. Make it prettier; more spaces between lines ✅
  2. Quantify the performance and compare to the other pull request

@timonmerk
Copy link
Contributor

Cool! Do you see it "lagging" behind after stopping the stream? So that the visualization still takes more time to finish?

@ahmedtarek-
Copy link
Collaborator Author

@timonmerk It lags but for only a second or two. In general, it seems more performant. Here is the breakdown of performance.

Peformance comparison for 500 incoming messages (through Websocket)

  • [Echarts] without subscription -> 250 updates, 49 s
  • [Plotly] Restyle yTraces only -> 611 update, 121.921 s
  • [Plotly] React with subscription only -> 500 updates, 114.072 s
  • [Plotly] React without subscription -> 254 updates, 61 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants