Rework coverage for NMODL ODE solver and pybind - #3544
Conversation
Put back whatever hackery it used before to collect the mod files, if some of the files are missing coverage I really don't care.
|
✔️ e0e83ea -> artifacts URL |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3544 +/- ##
==========================================
+ Coverage 68.09% 68.31% +0.21%
==========================================
Files 689 689
Lines 111038 111038
==========================================
+ Hits 75615 75851 +236
+ Misses 35423 35187 -236 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✔️ e0e83ea -> Azure artifacts URL |
|
Okay, I am very confused how codecov is collecting and computing the coverage. For instance, I don't think this makes any sense:
This is taken from Note that one line (132) has no coverage, and then the line immediately following it (133), at the same indentation level, does have coverage? I have no idea what's going on here... |
|
✔️ c81be96 -> artifacts URL |
also add comment about using single triple quotes
…lic/refactor_coverage
|
|
✔️ 5cf9a74 -> artifacts URL |
|
✔️ 47fa629 -> Azure artifacts URL |
I had a quick look; examining the .coverage file seems to show more proper coverage (at least 133 and 132 are covered): I wonder if it makes more sense to have coverage just make the .coverage file, and do a post process step to create the single |
|
|
✔️ ca5369c -> Azure artifacts URL |
|
✔️ ca5369c -> artifacts URL |




Rework coverage so each invocation of
nrnivmodl -coreneuroncreates a coverage report if the ODE solver is used. Note that the coverage files may be littered across the source directory; this is due to the fact that nrnivmodl does too much "fixing" of paths of modfiles, so it's basically impossible to run it from the build directory itself (it does acdbeforehand).Also note that the coverage tool is broken (see below comment), so we do not get coverage of all of the lines.