Fix NMODL install paths - #3581
Conversation
|
|
✔️ 3d69b5e -> Azure artifacts URL |
|
✔️ 3d69b5e -> artifacts URL |
nrnhines
left a comment
There was a problem hiding this comment.
Assuming a trailing '/' on path variables seems strange to me. Wouldn't an alternative be to check the variable and demand it be non empty?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3581 +/- ##
=======================================
Coverage 68.46% 68.46%
=======================================
Files 685 685
Lines 116720 116720
=======================================
+ Hits 79914 79918 +4
+ Misses 36806 36802 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Those are already taken care of, all custom paths that we set have a trailing slash (except when calling Lines 43 to 58 in 3d69b5e The case of |



Fixes #3580.
Note that the various prefix forward slashes have been removed because if the preceding variable is empty, it will try to install it to the absolute path (for instance,
/bininstead ofbin, and the latter gets expanded to${CMAKE_INSTALL_PREFIX}bin, whereCMAKE_INSTALL_PREFIXalready takes care of the paths).