Use derivimplicit if cnexp solution contains an unimplemented function - #3590
Conversation
|
✔️ 0be6d6c -> artifacts URL |
|
✔️ 0be6d6c -> Azure artifacts URL |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3590 +/- ##
==========================================
+ Coverage 68.46% 68.47% +0.01%
==========================================
Files 686 686
Lines 116758 116771 +13
==========================================
+ Hits 79942 79963 +21
+ Misses 36816 36808 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✔️ 956ace0 -> artifacts URL |
|
✔️ 956ace0 -> Azure artifacts URL |
|
✔️ b18656a -> Azure artifacts URL |
|
✔️ b18656a -> artifacts URL |
|
✔️ 4ff6f36 -> artifacts URL |
|
✔️ 4ff6f36 -> Azure artifacts URL |
cattabiani
left a comment
cattabiani
left a comment
There was a problem hiding this comment.
LGTM and I approve in principle. I would prefer to have the opinion of someone else. I am rusty on nmodl.
PS: if you do not find anybody else, I will approve obv
|
|
✔️ 9d15879 -> Azure artifacts URL |
|
✔️ 9d15879 -> artifacts URL |
3 participants
Fixes #3579.
We check the
cnexpsolution for any "unimplementable" features (such as the presence of the Lambert W function), and raise a warning to the user that NMODL will usederivimplicitinstead.Note that we do not perform this check in the Python code itself (notably
ode.py) because it isn't aware of what is and isn't implemented in NEURON.