Skip to content

rxd handles np.float64 #3808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramcdougal merged 5 commits into from
Jun 25, 2026
Merged

rxd handles np.float64 #3808

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
31e8684
rxd handles np.float64
ramcdougal Jun 25, 2026
9941514
preserve ints
ramcdougal Jun 25, 2026
24070a2
simplified to just unwrapping numpy objects
ramcdougal Jun 25, 2026
d87e324
added a test
ramcdougal Jun 25, 2026
95affc9
formatting
ramcdougal Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion share/lib/python/neuron/rxd/rxdmath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,7 +740,7 @@
pass
return False

def _semi_compile(self, region, instruction):

Check failure on line 743 in share/lib/python/neuron/rxd/rxdmath.py

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 19 to the 15 allowed. 


See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ78RUCvv2bAtrO4ixwf&open=AZ78RUCvv2bAtrO4ixwf&pullRequest=3808
items = []
counts = []
items_append = items.append
Expand All @@ -750,7 +750,10 @@
try:
items_append(item._semi_compile(region, instruction))
except AttributeError:
items_append(f"{item!r}")
try:
items_append(repr(float(item)))
except (TypeError, ValueError):
items_append(f"{item!r}")
counts_append(count)
result = ""
for i, c in zip(items, counts):
Expand Down
Loading