Skip to content

CI/release: dry-run fixes (empty __version__, artifact-url, MPICH arm64) - #3842

Merged
nrnhines merged 4 commits into
masterfrom
hines-grok/release-dry-run-fixes
Aug 11, 2026
Merged

CI/release: dry-run fixes (empty __version__, artifact-url, MPICH arm64)#3842
nrnhines merged 4 commits into
masterfrom
hines-grok/release-dry-run-fixes

Conversation

@nrnhines

Copy link
Copy Markdown
Member

Summary

Port post–9.0.2 release hygiene to master so dry-runs controlled from master behave like the successful 9.0.2 ship path:

  1. Empty neuron.__version__ — when shallow clones make git describe fail, fall back to PROJECT_VERSION in add_cpp_git_information (plus wheel test assert). Cherry-picked from Fix empty neuron.__version__ when git describe fails in shallow clones #3840 / release/9.0.
  2. merge-wheels artifact URL — use artifact-url (not artifacts-url) so ModelDB/build-ci get this run’s wheels, not a nightly fallback. From hines-grok/release-modeldb-artifact-url.
  3. Ubuntu 24.04 arm64 MPICH pin — select amd64 vs arm64 debs in install_mpich_noble.sh so arm wheel tests don’t install wrong packages. From release/9.0.

Test plan

  • CI green on this PR
  • Optional: NEURON Release dry-run with workflow from this branch/master after merge, rel_branch=release/9.0 (or tip), upload=false — confirm non-empty __version__ and ModelDB V2 uses the run’s wheels artifact URL

Out of scope

Release dry-runs build wheels from a depth-1 checkout without creating the
release tag. git describe then fails while .git still exists, so GIT_DESCRIBE
stayed empty and neuron.__version__ (nrnversion(5)) was "", breaking ModelDB
CI workdir creation. Fall back to PROJECT_VERSION and assert non-empty
__version__ in wheel tests.
Host arm64 mpich/libmpich12 4.2.0-5.1 debs on nrn-ci-deps ci-deps-v1 and
select amd64 vs arm64 in install_mpich_noble.sh so ubuntu-24.04-arm wheel
jobs no longer try to dpkg amd64 packages (LP#2072338 pin).
actions/upload-artifact/merge@v4 exposes artifact-url, not artifacts-url.
The empty job output made Release ModelDB V2 fall back to neuron-nightly
instead of this run's wheels artifact.
@sonarqubecloud

Copy link
Copy Markdown

@nrnhines
nrnhines requested a review from ramcdougal August 11, 2026 13:10
@github-actions

Copy link
Copy Markdown
Contributor

✔️ 2da47ec -> artifacts URL

@nrnhines

Copy link
Copy Markdown
Member Author

@ramcdougal Please approve. This PR is the first phase of a plan for "post–9.0.2 release hygiene". It cherry-picks some release/9.0 changes that were needed for the 9.0.2 release.
Goal: land durable fixes on master, then tighten the release process so dry-run success predicts ship success without relearning 9.0.2 traps.
I'm expecting one or more future PR to have quite a few release documentation update and release workflow tweaks. Also release template issue adjustments.

@azure-pipelines

Copy link
Copy Markdown

✔️ 2da47ec -> Azure artifacts URL

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.39%. Comparing base (2b29967) to head (2da47ec).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3842      +/-   ##
==========================================
+ Coverage   68.37%   68.39%   +0.02%     
==========================================
  Files         700      700              
  Lines      112198   112198              
==========================================
+ Hits        76710    76736      +26     
+ Misses      35488    35462      -26     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nrnhines
nrnhines merged commit 2a21b48 into master Aug 11, 2026
44 checks passed
@nrnhines
nrnhines deleted the hines-grok/release-dry-run-fixes branch August 11, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants