Skip to content

IDA consistent IC: dae_init_mode, battery hold, forcing t+, source currents - #3845

Open
nrnhines wants to merge 24 commits into
masterfrom
hines-grok/ida-init
Open

IDA consistent IC: dae_init_mode, battery hold, forcing t+, source currents#3845
nrnhines wants to merge 24 commits into
masterfrom
hines-grok/ida-init

Fix sanitizer CI for IDA init/source-current hoctests

a108b2a
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Aug 13, 2026 in 13m 0s

Quality Gate passed

Issues
185 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 111 in test/unit_tests/vecplay_tplus.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define each identifier in a dedicated statement. 

See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ_8XKFnfTSSPHIR0AER&open=AZ_8XKFnfTSSPHIR0AER&pullRequest=3845

Check failure on line 334 in src/nrniv/linmod.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rewrite the code so that you no longer need this "delete". 

See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ_8XKNefTSSPHIR0AGU&open=AZ_8XKNefTSSPHIR0AGU&pullRequest=3845

Check warning on line 366 in src/nrncvode/cvodeobj.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused parameter "v", make it unnamed, or declare it "[[maybe_unused]]". 

See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ_8XKK4fTSSPHIR0AEb&open=AZ_8XKK4fTSSPHIR0AEb&pullRequest=3845

Check warning on line 431 in src/nrniv/nrndae.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "have_dforce" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ_8XKNDfTSSPHIR0AF2&open=AZ_8XKNDfTSSPHIR0AF2&pullRequest=3845

Check failure on line 333 in src/nrnoc/solve.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Global variables should be const. 

See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ_8XKR4fTSSPHIR0AGz&open=AZ_8XKR4fTSSPHIR0AGz&pullRequest=3845

Check warning on line 84 in test/unit_tests/vecplay_tplus.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid explicitly specifying the template arguments by relying on the class template argument deduction. 

See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ_8XKFnfTSSPHIR0AEK&open=AZ_8XKFnfTSSPHIR0AEK&pullRequest=3845

Check warning on line 41 in test/unit_tests/vecplay_tplus.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid explicitly specifying the template arguments by relying on the class template argument deduction. 

See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ_8XKFnfTSSPHIR0AEB&open=AZ_8XKFnfTSSPHIR0AEB&pullRequest=3845

Check warning on line 774 in src/nrnoc/extcelln.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this variable a pointer-to-const. The current type of "nde" is "struct Extnode *". 

See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ_8XKPhfTSSPHIR0AGs&open=AZ_8XKPhfTSSPHIR0AGs&pullRequest=3845

Check warning on line 848 in src/nrncvode/nrndaspk.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this variable a pointer-to-const. The current type of "pyp" is "double *". 

See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ_8XKLefTSSPHIR0AFH&open=AZ_8XKLefTSSPHIR0AFH&pullRequest=3845

Check failure on line 810 in src/nrnoc/extcelln.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ_8XKPhfTSSPHIR0AGo&open=AZ_8XKPhfTSSPHIR0AGo&pullRequest=3845

Check warning on line 105 in test/unit_tests/vecplay_tplus.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid explicitly specifying the template arguments by relying on the class template argument deduction. 

See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ_8XKFnfTSSPHIR0AEP&open=AZ_8XKFnfTSSPHIR0AEP&pullRequest=3845

Check failure on line 265 in src/nrniv/linmod.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ_8XKNefTSSPHIR0AGO&open=AZ_8XKNefTSSPHIR0AGO&pullRequest=3845

Check warning on line 74 in test/unit_tests/vecplay_tplus.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid explicitly specifying the template arguments by relying on the class template argument deduction. 

See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ_8XKFnfTSSPHIR0AEH&open=AZ_8XKFnfTSSPHIR0AEH&pullRequest=3845

Check failure on line 625 in src/nrncvode/nrndaspk.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ_8XKLefTSSPHIR0AEz&open=AZ_8XKLefTSSPHIR0AEz&pullRequest=3845

Check warning on line 339 in src/nrniv/nrndae.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this C-style array with "std::vector" (for dynamic size), or "std::array" (for static size) 

See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ_8XKNDfTSSPHIR0AF1&open=AZ_8XKNDfTSSPHIR0AF1&pullRequest=3845

Check warning on line 1102 in src/nrncvode/nrndaspk.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::print" instead of "fprintf". 

See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ_8XKLefTSSPHIR0AFZ&open=AZ_8XKLefTSSPHIR0AFZ&pullRequest=3845

Check failure on line 659 in src/nrncvode/nrndaspk.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Global variables should be const. 

See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ_8XKLefTSSPHIR0AE7&open=AZ_8XKLefTSSPHIR0AE7&pullRequest=3845

Check warning on line 422 in src/nrniv/vrecord.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::print" instead of "fprintf". 

See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ_8XKMefTSSPHIR0AFw&open=AZ_8XKMefTSSPHIR0AFw&pullRequest=3845

Check failure on line 755 in src/nrnoc/extcelln.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 51 to the 25 allowed. 

See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ_8XKPhfTSSPHIR0AGm&open=AZ_8XKPhfTSSPHIR0AGm&pullRequest=3845

Check warning on line 29 in test/unit_tests/vecplay_tplus.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define each identifier in a dedicated statement. 

See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ_8XKFnfTSSPHIR0AD9&open=AZ_8XKFnfTSSPHIR0AD9&pullRequest=3845

Check warning on line 244 in src/nrniv/linmod.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this C-style array with "std::vector" (for dynamic size), or "std::array" (for static size) 

See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ_8XKNefTSSPHIR0AGT&open=AZ_8XKNefTSSPHIR0AGT&pullRequest=3845

Check failure on line 75 in src/nrniv/linmod.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the "nullptr" literal. 

See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ_8XKNefTSSPHIR0AGJ&open=AZ_8XKNefTSSPHIR0AGJ&pullRequest=3845

Check failure on line 813 in src/nrnoc/extcelln.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ_8XKPhfTSSPHIR0AGp&open=AZ_8XKPhfTSSPHIR0AGp&pullRequest=3845

Check failure on line 438 in src/nrniv/nrndae.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ_8XKNDfTSSPHIR0AF-&open=AZ_8XKNDfTSSPHIR0AF-&pullRequest=3845

Check failure on line 619 in src/nrnoc/treeset.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 41 to the 25 allowed. 

See more on https://sonarcloud.io/project/issues?id=neuronsimulator_nrn&issues=AZ_8XKQsfTSSPHIR0AGt&open=AZ_8XKQsfTSSPHIR0AGt&pullRequest=3845
View more details on SonarQubeCloud