Skip to content

Conversation

@valosekj
Copy link
Member

@valosekj valosekj commented Jan 22, 2025

Experimental PR for my MRI analysis. Changes:

  • Handle ValueError: y_true and y_pred contain different number of classes
  • Set default LogisticRegression solver to saga to make it work for RFE

valosekj and others added 4 commits January 21, 2025 17:06
…true_and_y_pred' of github.com:SomeoneInParticular/modular_optuna_ml into jv/experimental-fix_different_num_of_classes_between_y_true_and_y_pred
@SomeoneInParticular

This comment was marked as outdated.

@valosekj valosekj marked this pull request as ready for review January 27, 2025 21:07
@valosekj

This comment was marked as outdated.

@SomeoneInParticular

This comment was marked as outdated.

@valosekj

This comment was marked as outdated.

@valosekj valosekj marked this pull request as draft January 29, 2025 12:23
@valosekj valosekj added the experimental Related to elements of the code base which are volatile and/or not guaranteed to be implemented. label Jan 29, 2025
@valosekj valosekj changed the title Handle different number of classes between y_true and y_pred Jan MRI analysis Feb 13, 2025
@valosekj valosekj changed the title Jan MRI analysis Jan's MRI analysis Feb 13, 2025
Copy link
Collaborator

@SomeoneInParticular SomeoneInParticular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the extreme delay on this, I swore I had submitted a review, but it seems it was pending this entire time

'UEMS_change_bin': 'UEMS Change',
'LEMS_change_bin': 'LEMS Change',
'AIS_change_bin_gt0': 'AIS Change'
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to remove these hard-coded elements and move them to a CLI. I don't mind spinning one up as a proof-of-concept, but I don't have your data, so you'd have to validate that it still works on your data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

experimental Related to elements of the code base which are volatile and/or not guaranteed to be implemented.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants