[ENH] Add option to cast to another data type#35
Draft
balbasty wants to merge 2 commits into
Draft
Conversation
Contributor
|
Note that U16 is now supported by freesurfer in versions 8+ freesurfer/freesurfer#1427 |
Member
|
Hi @balbasty @chourroutm, I was just going through old PRs. Checking to see if this is still needed or if we should close since freesurfer has been updated? |
Contributor
Author
|
I still think it's useful to convert between data types. I am pretty sure this PR works, it just needs testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change was suggested by @chourroutm, because some tools that handle niftis do not properly support all data types (e.g. Freeview does not like U16), and some tools that handle zarrs do not properly support a different set of data types (e.g., Neuroglancer (used to?) not like F64).
Not tested yet, hence draft mode.