DOC: expand explanation on why generic MCC methods are suboptimal (Is… - #1127
DOC: expand explanation on why generic MCC methods are suboptimal (Is…#1127Achintyasingh412 wants to merge 3 commits into
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis documentation-only change expands the CBMA guidance around the limitations of generic MCC methods, helping reviewers verify that the explanation is accurate, clear, and consistent with the documented analysis workflow. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
jdkent
left a comment
There was a problem hiding this comment.
Thanks for the contribution, since you are referencing papers, we can cite them using restructured text, you will need to either add/use the reference in this file: https://github.com/neurostuff/NiMARE/blob/main/nimare/resources/references.bib
and cite it like :footcite:p:smith2009threshold in the document.
|
|
||
| It can be applied to coordinate-based meta-analyses as an alternate metric to the | ||
| maximum summary statistic (``level-voxel``), cluster mass (``desc-mass``), or cluster size (``desc-size``). | ||
| However, recent work by Frahm et al. :footcite:p:`frahm2022evaluation` has indicated that the costs of performing |
There was a problem hiding this comment.
here is an example of a citation.
There was a problem hiding this comment.
"Hi @jdkent, thank you for the helpful review and the citation example! I'll update the formatting right away and push the fix shortly."
|
Hi @jdkent, thank you for the guidance! I've updated the Frahm citation to use the :footcite:p: format as requested Please let me know if it looks good to go now. |
jdkent
left a comment
There was a problem hiding this comment.
thanks for the change, please add a citeation for Eickhoff as well.
| Generic multiple-comparison correction methods fail to properly account for | ||
| the spatial smoothness, correlation, and null distribution characteristics | ||
| unique to coordinate-based meta-analyses like ALE. As outlined by | ||
| Eickhoff et al. (2016) and Frahm et al. :footcite:p:`frahm2022evaluation`, |
There was a problem hiding this comment.
please add the citation for Eickoff et al. 2016 as well.
|
Hi @jdkent, thanks for catching that! I've added the Sphinx footcite tag for Eickhoff et al. (2016) right alongside Frahm. Please let me know if everything looks good to go now |
|
Hey @jdkent, just dropping a friendly ping on this PR whenever you have a spare moment to review. Let me know if any adjustments or further clarifications are needed! |
Closes # .
Changes proposed in this pull request:
Summary by Sourcery
Documentation: