[CI] add windows - #995
Merged
Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the CI test workflow to add Windows to the OS matrix and replaces make-based test invocations with explicit pip/pytest commands that are more portable across platforms while preserving coverage collection and test selection via markers. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since the matrix now includes
windows-latestbut the steps still forceshell: bash {0}, consider explicitly configuring an appropriate shell per OS (e.g.,bashfor *nix andpwshfor Windows) or using the default shell so that Windows runners don’t depend on Git Bash being present. - The long
python -m pytest ...command is duplicated across multiple jobs; extracting the common arguments into a job-levelenvvariable or a composite/reusable action would reduce duplication and make future changes to the test invocation less error-prone.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since the matrix now includes `windows-latest` but the steps still force `shell: bash {0}`, consider explicitly configuring an appropriate shell per OS (e.g., `bash` for *nix and `pwsh` for Windows) or using the default shell so that Windows runners don’t depend on Git Bash being present.
- The long `python -m pytest ...` command is duplicated across multiple jobs; extracting the common arguments into a job-level `env` variable or a composite/reusable action would reduce duplication and make future changes to the test invocation less error-prone.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #995 +/- ##
==========================================
- Coverage 86.60% 86.50% -0.10%
==========================================
Files 51 51
Lines 9076 9125 +49
==========================================
+ Hits 7860 7894 +34
- Misses 1216 1231 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes # .
Changes proposed in this pull request:
Summary by Sourcery
Expand and standardize continuous integration testing across platforms and test suites.
CI:
python -m pipacross all jobs.