Skip to content

[CI] add windows - #995

Merged
jdkent merged 6 commits into
neurostuff:mainfrom
jdkent:ci/windows
Mar 31, 2026
Merged

[CI] add windows#995
jdkent merged 6 commits into
neurostuff:mainfrom
jdkent:ci/windows

Conversation

@jdkent

@jdkent jdkent commented Mar 31, 2026

Copy link
Copy Markdown
Member

Closes # .

Changes proposed in this pull request:

Summary by Sourcery

Expand and standardize continuous integration testing across platforms and test suites.

CI:

  • Add Windows runners to the main test matrix in the GitHub Actions workflow.
  • Standardize package installation in CI by using python -m pip across all jobs.
  • Replace make-based test invocations in CI with explicit pytest commands and markers for different test groups.

@sourcery-ai

sourcery-ai Bot commented Mar 31, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the CI test workflow to add Windows to the OS matrix and replaces make-based test invocations with explicit pip/pytest commands that are more portable across platforms while preserving coverage collection and test selection via markers.

File-Level Changes

Change Details Files
Extend CI matrix to test on Windows in addition to existing platforms.
  • Add windows-latest to the OS matrix for the main test job that runs across Python 3.10–3.14
.github/workflows/testing.yml
Make Python package installation commands explicit and more portable.
  • Replace bare pip install -e .[...] calls with python -m pip install -e .[...] to ensure the correct interpreter is used across platforms, including Windows
  • Apply this change consistently across all jobs (full tests, minimum-deps tests, performance estimator/corrector/smoke, and cbmr_importerror jobs)
.github/workflows/testing.yml
Replace make-based test commands with direct pytest invocations while preserving coverage options and marker selection.
  • Change make unittest to a direct python -m pytest invocation filtering out performance and cbmr_importerror markers and enabling coverage with --cov-append --cov-report=xml --cov=nimare
  • Change make test_performance_estimators to python -m pytest -m "performance_estimators" with the same coverage options
  • Change make test_performance_correctors to python -m pytest -m "performance_correctors" with the same coverage options
  • Change make test_performance_smoke to python -m pytest -m "performance_smoke" with the same coverage options
  • Change make test_cbmr_importerror to python -m pytest -m "cbmr_importerror" with the same coverage options
.github/workflows/testing.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since the matrix now includes windows-latest but the steps still force shell: bash {0}, consider explicitly configuring an appropriate shell per OS (e.g., bash for *nix and pwsh for Windows) or using the default shell so that Windows runners don’t depend on Git Bash being present.
  • The long python -m pytest ... command is duplicated across multiple jobs; extracting the common arguments into a job-level env variable or a composite/reusable action would reduce duplication and make future changes to the test invocation less error-prone.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since the matrix now includes `windows-latest` but the steps still force `shell: bash {0}`, consider explicitly configuring an appropriate shell per OS (e.g., `bash` for *nix and `pwsh` for Windows) or using the default shell so that Windows runners don’t depend on Git Bash being present.
- The long `python -m pytest ...` command is duplicated across multiple jobs; extracting the common arguments into a job-level `env` variable or a composite/reusable action would reduce duplication and make future changes to the test invocation less error-prone.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov

codecov Bot commented Mar 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.27273% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.50%. Comparing base (dd6f578) to head (1084936).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
nimare/utils.py 76.19% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #995      +/-   ##
==========================================
- Coverage   86.60%   86.50%   -0.10%     
==========================================
  Files          51       51              
  Lines        9076     9125      +49     
==========================================
+ Hits         7860     7894      +34     
- Misses       1216     1231      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jdkent
jdkent merged commit 6e8fa57 into neurostuff:main Mar 31, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant