-
Notifications
You must be signed in to change notification settings - Fork 1
PERF: avoid unnecessary array copy for single-pass convolution #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
431356a to
86938ae
Compare
|
This is stable. Before I undraft, squash and merge, I want to address two points:
|
|
I'm actually seeing a 5% performance regression with this patch. I'll re-issue the various independent parts of the PR piecemeal to reduce my cognitive overload deciphering this. |
bede295 to
d261e9a
Compare
7f9ce90 to
d518f4f
Compare
|
I think I've been looking at this from the wrong angle; I was assuming that my |
|
(dispatching at the Python level instead doesn't improve performance) |
|
(forcing inlining on |
d518f4f to
02a7c83
Compare
|
The good news is that #172 more than compensates for the loss in performance from this patch, but I still would like to figure out why this is slower than |
55c57d1 to
2df507c
Compare
7b1779c to
e471400
Compare
e471400 to
63b4b16
Compare
|
rebased, but I'm still seeing about 2% (unexplained) overhead. |
63b4b16 to
fb67ea9
Compare
Close #85
Incidentally, close #114
I checked that binary size doesn't noticibly increase with this refactor, lifting my comment from #85