Open
Conversation
jcompagni10
force-pushed
the
feat/sv_calculations
branch
from
54da8d3 to
03c527d
Compare
dib542
requested changes
Sep 9, 2025
Contributor
dib542
left a comment
dib542
left a comment
There was a problem hiding this comment.
Looks good, but found some spelling/grammar that should be updated though
| 2. **Taker Volume** When trades where the vault is trading through liquidity already on the orderbook. | ||
|
|
||
| #### Total Value Locked (TVL) | ||
| TVL is the total value of tokens in the vault. This is effectively the sum of net deposits and vault revenue. |
Contributor
There was a problem hiding this comment.
probably implied, but did you want to specify:
Suggested change
| TVL is the total value of tokens in the vault. This is effectively the sum of net deposits and vault revenue. | |
| TVL is the total value of tokens in the vault. This is effectively the sum of net deposits - withdrawals and vault revenue. |
Contributor
Author
There was a problem hiding this comment.
Net deposits feels pretty clear to me.
Co-authored-by: David Uhlmann <dib542@gmail.com>
Co-authored-by: David Uhlmann <dib542@gmail.com>
Co-authored-by: David Uhlmann <dib542@gmail.com>
dib542
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain supervault metrics