Draft
Conversation
sotnikov-s
requested changes
Nov 30, 2022
|
|
||
| #### Keyring settings | ||
|
|
||
| - `RELAYER_NEUTRON_CHAIN_KEYRING_BACKEND` — the type of backend (more about keyring types [here](https://docs.cosmos.network/master/run-node/keyring.html#the-kwallet-backend)); |
Contributor
There was a problem hiding this comment.
do you think we need the NEUTRON_CHAIN part in these variable names? I'd simplify to RELAYER_KEYRING_BACKEND and so on:
- we don't have corresponding values for the target chain, so no need to specify it. I mean, it should be obvious that we have keyring-related values only at the neutron's side, whereas such
NEUTRON_CHAINparts in names would only confuse the user like "oh, here's neutron's side keyring... is there a not-neutron's side keyring...?"; - these are not the neutron chain specific values, these are relayer's values.
given the above, I'd remove the NEUTRON_CHAIN part from all keyring related variables and also moved the gas-related values to this, say, "group":
RELAYER_NEUTRON_CHAIN_RPC_ADDR
RELAYER_NEUTRON_CHAIN_REST_ADDR
RELAYER_NEUTRON_CHAIN_HOME_DIR
RELAYER_NEUTRON_CHAIN_TIMEOUT
RELAYER_NEUTRON_CHAIN_CONNECTION_ID
RELAYER_NEUTRON_CHAIN_OUTPUT_FORMAT
RELAYER_NEUTRON_CHAIN_DEBUG
RELAYER_KEYRING_BACKEND
RELAYER_KEYRING_PASSWORD
RELAYER_SIGN_KEY_NAME
RELAYER_SIGN_KEY_SEED
RELAYER_SIGN_KEY_HD_PATH
RELAYER_SIGN_MODE_STR
RELAYER_GAS_PRICES
RELAYER_GAS_LIMIT
RELAYER_GAS_ADJUSTMENT
RELAYER_TARGET_CHAIN_RPC_ADDR
RELAYER_TARGET_CHAIN_ACCOUNT_PREFIX
RELAYER_TARGET_CHAIN_VALIDATOR_ACCOUNT_PREFIX
RELAYER_TARGET_CHAIN_TIMEOUT
RELAYER_TARGET_CHAIN_DEBUG
RELAYER_TARGET_CHAIN_OUTPUT_FORMAT
RELAYER_REGISTRY_ADDRESSES
what do you think?
|
|
||
| ``` | ||
| ... | ||
| RELAYER_NEUTRON_CHAIN_KEYRING_BACKEND=test |
Contributor
There was a problem hiding this comment.
here should've been RELAYER_NEUTRON_CHAIN_KEYRING_BACKEND=memory I presume
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: https://p2pvalidator.atlassian.net/browse/NTRN-195
ICQ relayer PR: neutron-org/neutron-query-relayer#53
Tests: neutron-org/neutron-integration-tests#31