-
Notifications
You must be signed in to change notification settings - Fork 122
Table map and error event improvements #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: error_handling
Are you sure you want to change the base?
Conversation
' AND t.CONSTRAINT_NAME = k.CONSTRAINT_NAME', | ||
' WHERE c.TABLE_SCHEMA = "%s"', | ||
' AND c.TABLE_NAME = "%s"' | ||
].join(' ').replace(/\s{2,}/g, ' '); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how a DBA taught me to format SQL for readability, it's opinionated so I'm fine with just truncating it at 80 characters onto however many lines if that makes everyone happy.
It seemed like a good idea to get rid of the extra spaces once rather than sending them over with every query. If the join
bothers anyone it can be converted to a string, it's only going to run once so performance shouldn't be a concern.
…red while trying to read the information_schema
… flags to each column.
…tive MySQL timezone
Improvements:
ctrlConnection
errors and unhandledErrors will be relayed by Zongjiconstraints
(null or object) andnullable
(boolean) properties.For discussion
type
rather than the code. Will this break anything internally?Given the following DDL:
Your table map columns would look like this: