Weapons from Delta-V#2527
Merged
Cheackraze merged 16 commits intonew-frontiers-14:masterfrom Jan 12, 2025
Merged
Conversation
Contributor
|
RSI Diff Bot; head commit c25f1c9 merging into ef05f0d Resources/Textures/DeltaV/Objects/Weapons/Guns/Pistols/pollock.rsi
Resources/Textures/DeltaV/Objects/Weapons/Guns/Pistols/universal.rsi
Resources/Textures/DeltaV/Objects/Weapons/Guns/Revolvers/faith.rsi
Resources/Textures/DeltaV/Objects/Weapons/Guns/Revolvers/fitz.rsi
Resources/Textures/DeltaV/Objects/Weapons/Guns/Revolvers/lucky.rsi
Resources/Textures/DeltaV/Objects/Weapons/Guns/Rifles/ceremonial_grand.rsi
Resources/Textures/DeltaV/Objects/Weapons/Guns/Rifles/jackdaw.rsi
Resources/Textures/DeltaV/Objects/Weapons/Guns/Rifles/vulcan.rsi
|
Resources/Prototypes/DeltaV/Entities/Objects/Weapons/Guns/Revolvers/revolvers.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/DeltaV/Entities/Objects/Weapons/Guns/Revolvers/revolvers.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/DeltaV/Entities/Objects/Weapons/Guns/Revolvers/revolvers.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/DeltaV/Entities/Objects/Weapons/Guns/Pistols/pistols.yml
Show resolved
Hide resolved
Resources/Prototypes/_NF/Entities/Markers/Spawners/Random/dungeon_items_weapons.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/DeltaV/Entities/Objects/Weapons/Guns/Pistols/pistols.yml
Outdated
Show resolved
Hide resolved
|
Love it. |
Contributor
Author
|
@ErhardSteinhauer , thank you for your review. I will correct all my mistakes |
whatston3
reviewed
Dec 10, 2024
Contributor
whatston3
left a comment
whatston3
left a comment
There was a problem hiding this comment.
Weapon names should be capitalized (consistent with upstream and our own guns).
Values are strangely high.
Unless the Jackdaw is intended to be a meme, the accuracy may need a tweak since it's wieldable.
Resources/Prototypes/DeltaV/Entities/Objects/Weapons/Guns/Rifles/rifles.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/DeltaV/Entities/Objects/Weapons/Guns/Revolvers/revolvers.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/DeltaV/Entities/Objects/Weapons/Guns/Revolvers/revolvers.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/DeltaV/Entities/Objects/Weapons/Guns/Revolvers/revolvers.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/DeltaV/Entities/Objects/Weapons/Guns/Revolvers/revolvers.yml
Show resolved
Hide resolved
Resources/Prototypes/DeltaV/Entities/Objects/Weapons/Guns/Pistols/pistols.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/DeltaV/Entities/Objects/Weapons/Guns/Rifles/rifles.yml
Outdated
Show resolved
Hide resolved
Contributor
iirc, it's a DS gun. |
Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com>
Contributor
Author
|
@whatston3 thank you. |
ErhardSteinhauer
previously requested changes
Dec 13, 2024
Resources/Prototypes/_NF/Catalog/VendingMachines/Inventories/weaponryworks.yml
Outdated
Show resolved
Hide resolved
|
Are you making the vending machine viper illegal or legal? Because it is technically a common gun that is just preferred by syndicate, even though civies can get access to it. |
GreaseMonk
approved these changes
Jan 10, 2025
Contributor
|
Have to revert this or fix name space this PR is broken per _DV |
GreaseMonk
pushed a commit
that referenced
this pull request
Jan 12, 2025
dvir001
added a commit
that referenced
this pull request
Jan 12, 2025
Cheackraze
pushed a commit
that referenced
this pull request
Jan 18, 2025
* Revert "Revert "Weapons from Delta-V (#2527)" (#2692)" This reverts commit 1fac436. * Fix * Fix left * Fix * Fix * Fix * reduce vulcan price, wieldable ceremonial rifle * expedition gun variation, universal buff & swap * add typewriter gun, copy universal sound * Revert "AkExpedition" references * Revert weapon case name change --------- Co-authored-by: Whatstone <whatston3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
The weapons were taken from Delta-V
Thanks to @bing268 for his help with the creation
New weapons added:
Why / Balance
New weapons are created for more variety
Media
Changelog