Skip to content

Kegs (DeltaV 2378#)#2618

Merged
dvir001 merged 10 commits intonew-frontiers-14:masterfrom
dvir001:2024-12-26-Kegs
Dec 29, 2024
Merged

Kegs (DeltaV 2378#)#2618
dvir001 merged 10 commits intonew-frontiers-14:masterfrom
dvir001:2024-12-26-Kegs

Conversation

@dvir001
Copy link
Contributor

@dvir001 dvir001 commented Dec 26, 2024

About the PR

DeltaV-Station/Delta-v#2378

Added wooden barrels and kegs. Wine, Beer, and Root Beer kegs.

Why / Balance

Drinks

How to test

N/A

Media

image

Requirements

Technical details

Both are fully constructible and deconstructible (though with no SpillAllSolutions completion in constructions, I just used the SolutionEmpty condition to prevent deconstruction of a keg with anything in it). Base wooden barrel sprite adapted from tgstation/tgstation#38977 but redone to fit the style better, plus I sprited the keg wholecloth.

Regular wooden barrel acts like a crate, wooden keg acts like a tank. Keg is set to 500 1000 volume; I felt like it needed to be larger than jugs, but not as large as tanks (which are 1500). Wooden kegs and wooden barrels can be constructed with 5 wood (a la crates), but that can be increased if necessary. They are also vaultable :)

Refilling kegs is a bit annoying, but doable, with the best approach being dragging jugs onto them similar to the chemmaster. You can also inject into them with syringes. Clicking on them with a bottle or anything will just fill that container, similar to a water cooler. You can also drink directly from them.

Changelog
🆑

  • add: Added wooden barrels and wooden kegs.
  • tweak: Converted the mini kegs into casks

@github-actions
Copy link
Contributor

github-actions bot commented Dec 26, 2024

RSI Diff Bot; head commit 4c8f922 merging into 0686ef9
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Consumable/Drinks/keg_steel.rsi

State Old New Status
icon Modified
icon_open Removed
stopper Added

Resources/Textures/_NF/Objects/Consumable/Drinks/keg_wood.rsi

State Old New Status
icon Modified
icon_open Removed
stopper Added

Resources/Textures/DeltaV/Objects/Storage/keg.rsi

State Old New Status
base Added

Edit: diff updated after 4c8f922

@github-actions github-actions bot added the Map-Shuttle Map - Shuttle label Dec 26, 2024
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Dec 26, 2024
Copy link
Contributor

@GreaseMonk GreaseMonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like kegs are trending right now

@dvir001
Copy link
Contributor Author

dvir001 commented Dec 29, 2024

Kegs life

@dvir001 dvir001 merged commit f8a0b13 into new-frontiers-14:master Dec 29, 2024
16 checks passed
FrontierATC added a commit that referenced this pull request Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Map-Shuttle Map - Shuttle No C# S: Needs Review This PR is awaiting reviews Sprites YML

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants