lobby arts and sounds#4234
Conversation
github-actions
bot
added
S: Untriaged
size/M
S: Needs Review
|
Please check if the ingame roundend volume is fine, it wasa bit quiet on my test, might be a client issue tho. |
|
Also, there are two commented lobby screens, if they wont get used why not remove them? |
|
I want to redo the announcements.. converting to draft |
…-station-14 into lobby-art-and-sound
…ntier-station-14 into lobby-art-and-sound
There was a problem hiding this comment.
Works and looks pretty sweet! The only thing I have a hard time testing, are the round end announcements... I'm not sure how it works, but they seem to very rarely trigger? Most likely a skill issue on my part
The only note I have right now, is that the plantyful sadly does not work that well, compared to the others? I feel like the UI hides the part of the drawing that has the most stuff going on... I don't know, might just be me?
(Oh, also, you were missing the :cl: on your changelog, I fixed it for you!)
|
I have not yet listened to the music, but I've been told that there is one sound file that contains copyrighted music as either a dub or as part of another song. If that isn't the case, cool and good, if it is the case that should be given a deeper look. |
The best way I found to reliably get the end of round voicelines to play is to:
This was my method for a previous pr on another fork that added new end of round sound clips :) |
|
Did the owners of the song sampled in bangingweh.ogg give permission for their work to be added to the game? If not, that one needs to be removed. If so, please add proof of the permission to the PR. |
The sound was mixed up by me, the original is from goonstation. I belive the origigigigiginal is some old british yt video. |
|
yea i just looked for it, cant find info if it is cc, gonna remove it |
ErhardSteinhauer
left a comment
ErhardSteinhauer
left a comment
There was a problem hiding this comment.
Seems fine on my end, love the art.
P.S.: Two more reasons to keep Lobby and Round end sound slider at 0%
ErhardSteinhauer
added
S: Needs Review
6 participants
About the PR
Added some artworks as lobby art.
Increased volume of snakeradio sound and added more round restart sounds.
Why / Balance
Sandwich
Technical details
added soundfiles to /audio/announcements/roundend
added images and yml to /textures/_NF/lobbyscreens
How to test
you wouldnt belive it, by restarting the round
Make sure to do end round followed by restart round now so you dont have to wait for 2 minutes
Media
Requirements
Breaking changes
Changelog
🆑