Moved the shipyard sell button to the right side of the screen, also made it a ConfirmButton#4341
Open
nicholas477 wants to merge 1 commit intonew-frontiers-14:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Moved the sell button for the Shipyard UI to the right side of the screen (to avoid accidently clicking it when ejecting the ID)
Made the sell button a ConfirmButton (to match the ship purchase button). Currently, ConfirmButtons are bugged (space-wizards/space-station-14#43009) so the button being disabled after selling isn't working, unfortunately.
Why / Balance
I accidently sold my ship and now im mad!!! I didn't like the sell button being right next to the eject ID button and having no "confirm" state so that's why I made this PR.
Technical details
Replaced the shipyard eject/sell grid container with a vertical container, moved the sell button to the right, moved the "Insert your ID to buy/sell" text below the buttons.
How to test
Try to sell a purchased ship, it should ask to confirm. (NOTE: the button should be disabled after selling, since you don't have a ship. But the confirm button is bugged so it will appear enabled, unfortunately.)
Media
Video
Requirements
Breaking changes
Changelog
🆑