cobble brick walls now propely connect - #4799
Conversation
…ck smooth with walls
github-actions
Bot
added
S: Needs Review
|
For mapping I guess this makes sense, but I was really looking forward to using these asteroid walls for in-round building, and that's going to be a lot less feasible if they've got the plasteel cost of reinforced. Would it be terribly much to ask that we keep a basic wall variant as well? |
you know, that was what i originally had in mind, then i was reminded that keeping it that way would make it awkward mapping rules wise so i made this PR. having a second facade wall that's a reinforced facade wall would solve this issue, but i'm not sure if it'd be feature bloat or not when it's literally just the same as a regular facade wall just with more health and needing plasteel... and i'd feel a little bad if i expected the rules to bend around them since... that'd be showing favortisim to myself. although i guess if someone was to build with them they'd instead just use the actual rock walls? maybe it would be fine if i kept the facade walls as is... |
How do you figure? 🤔 |
as in the exterior walls should be reinforced walls, or better stat wise. the geode does have regular rocks on its exterior, so i guess facade rock walls wouldn't really be needed for mapping. i actually remember now, the only reason i made the facade walls was for building; regular rock walls already exist, i just forgot that by the time it was merged since i worked on it several months ago. i've reverted the facade changes. |
Bartholemew-Dingleberry
changed the title
Do you imagine the brick walls would be suitable as a prefab shuttle wall?! I dunno about that one... |
how else will we get castle style ships? i mean they look like regular brick walls, but that's just a superficial layer, the actual wall is just the same as a reinforced one. hence its construction graph. |
|
i'd have made it make a facade brick wall to be able to edit the description without affecting anything that already/might use them, but that'd be closer to feature bloat... |
…bblebrick as a parent
|
i have no idea why the tests are failing, i suspected it was because of the aditional keys component not being on the other cobble walls, but now that i've added it to them all it fails the tests regardless. trying to read the error says the issue is with the cobble brick walls with crabs in them, but none of the parents should override the iconsmoothing component. it seems to talk about a "missing string" which i assumed was the additional keys string, which is why i tried adding them explicitly to each cobble brick wall, but now i'm not sure what the issue is.... |
| acts: ["Destruction"] # Frontier | ||
| - type: IconSmooth | ||
| key: cobblebricks | ||
| additionalKeys: walls # Frontier: added walls as an additional key. |
There was a problem hiding this comment.
additionalKeys needs a list. You have to write either of these:
# first option:
additionalKeys: [walls]
# second option:
additionalKeys:
- wallsThere was a problem hiding this comment.
a group of one huh, relatable.
…ter to understand it's a group of one (dumbass)
3 participants
About the PR
Why / Balance
Technical details
How to test
see asteroid cobble brick wall connect to windows and regular walls
Media
Requirements
Breaking changes
Changelog
🆑