Missing locales and typos cleanup - #4803
Open
Menshin wants to merge 5 commits into
Open
Conversation
Contributor
|
Not sure if it fits in this PR, but lemoon seed packets appear to also be lacking a localization string. |
Contributor
Author
On it. |
Alkheemist
requested changes
Aug 28, 2026
| tech-disk-ui-total-label = There are {$amount} points on the selected server | ||
| tech-disk-ui-cost-label = Each disk costs {$amount} points to print | ||
| tech-disk-ui-print-button = Print Disk | ||
| tech-disk-ui-print-button = Print Disk for {$amount} points # Frontier: added $amount part |
Contributor
Contributor
Author
There was a problem hiding this comment.
Darn, could have sworn it was working 👀
I'm leaving the lines in anyway, since the code is still present (or do you want me to comment it out ?)
Contributor
Author
|
Requested changes made, thanks for the review. |
Alkheemist
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

About the PR
Fixed typos in locale usage and added a missing locale for the
purchaseshipcommand. Most of these already existed and were either used in another part of the code or not used at all (typo).Fixes #4495.
Why / Balance
Bug fixes, better hints for commands.
Technical details
SiliconLawContainer.xaml.cs
silicon-law-print-error-->silicon-law-error(typo/non-updated key)Content.Server/_NF/Administration/Commands/GhostRoleWhitelistCommands.cs
Mostly typos/non-updated keys :
cmd-ghostrolewhitelist-ghost-role-does-not-exist-->cmd-ghostrolewhitelist-ghostrole-does-not-existcmd-ghostrolewhitelist-already-whitelisted-->cmd-ghostrolewhitelistadd-already-whitelisted(not sure why it was needed to have both ghostrolewhitelistADD and ghostrolewhitelistREMOVE strings but i've let them in)cmd-ghostrolewhitelist-hint-job-->cmd-ghostrolewhitelist-hint-ghostrolecmd-ghostrolewhitelist-job-does-not-exist-->cmd-ghostrolewhitelist-ghostrole-does-not-existContent.Server/_NF/Bank/StationATMSystem.cs
bank-withdraw-failed-->bank-atm-menu-transaction-denied(typo/non updated key)Content.Server/_NF/Shipyard/Commands/PurchaseShuttleCommand.cs
station-id-->cmd-hint-station-id(adding that one)Resources/Locale/en-US/_NF/bounty-contracts/bounty-contracts.ftl
bounty-contracts-ui-create-error-vessel-too-long-->bounty-contracts-ui-create-error-vessel-name-too-long(not to be confused with the bounty name 😇 )Resources/Locale/en-US/components/screen-component.ftl
Added missing
screen-local-gridResources/Locale/en-US/research/components/technology-disk.ftl
Changed
tech-disk-ui-print-button(because we somehow don't use the cost locale key) and addedtech-disk-ui-print-rare-button.Resources/Locale/en-US/round-notifications/notifications.ftl
Added
discord-round-unknown-mapEdit: added missing
seeds-lemoon-namefrom upstream (so no need for Frontier marking).How to test
Use any of the command related to the missing locales.
Requirements
Breaking changes
None.
Changelog
Not really player facing.