Skip to content

Missing locales and typos cleanup - #4803

Open
Menshin wants to merge 5 commits into
new-frontiers-14:masterfrom
Menshin:missingLocalizationStringsCleanup
Open

Missing locales and typos cleanup#4803
Menshin wants to merge 5 commits into
new-frontiers-14:masterfrom
Menshin:missingLocalizationStringsCleanup

Conversation

@Menshin

@Menshin Menshin commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

About the PR

Fixed typos in locale usage and added a missing locale for the purchaseship command. Most of these already existed and were either used in another part of the code or not used at all (typo).

Fixes #4495.

Why / Balance

Bug fixes, better hints for commands.

Technical details

  • SiliconLawContainer.xaml.cs
    silicon-law-print-error --> silicon-law-error (typo/non-updated key)

  • Content.Server/_NF/Administration/Commands/GhostRoleWhitelistCommands.cs
    Mostly typos/non-updated keys :
    cmd-ghostrolewhitelist-ghost-role-does-not-exist --> cmd-ghostrolewhitelist-ghostrole-does-not-exist
    cmd-ghostrolewhitelist-already-whitelisted --> cmd-ghostrolewhitelistadd-already-whitelisted (not sure why it was needed to have both ghostrolewhitelistADD and ghostrolewhitelistREMOVE strings but i've let them in)
    cmd-ghostrolewhitelist-hint-job --> cmd-ghostrolewhitelist-hint-ghostrole
    cmd-ghostrolewhitelist-job-does-not-exist --> cmd-ghostrolewhitelist-ghostrole-does-not-exist

  • Content.Server/_NF/Bank/StationATMSystem.cs
    bank-withdraw-failed --> bank-atm-menu-transaction-denied (typo/non updated key)

  • Content.Server/_NF/Shipyard/Commands/PurchaseShuttleCommand.cs
    station-id --> cmd-hint-station-id (adding that one)

  • Resources/Locale/en-US/_NF/bounty-contracts/bounty-contracts.ftl
    bounty-contracts-ui-create-error-vessel-too-long --> bounty-contracts-ui-create-error-vessel-name-too-long (not to be confused with the bounty name 😇 )

  • Resources/Locale/en-US/components/screen-component.ftl
    Added missing screen-local-grid

  • Resources/Locale/en-US/research/components/technology-disk.ftl
    Changed tech-disk-ui-print-button (because we somehow don't use the cost locale key) and added tech-disk-ui-print-rare-button.

  • Resources/Locale/en-US/round-notifications/notifications.ftl
    Added discord-round-unknown-map

Edit: added missing seeds-lemoon-name from upstream (so no need for Frontier marking).

How to test

Use any of the command related to the missing locales.

Requirements

  • I have read CONTRIBUTING.md and and am following the Pull Request and Changelog Guidelines.
  • I have added media to this PR or it does not require an ingame showcase.
  • I confirm that the content in this PR is my own work, and/or is properly attributed to the original author(s).

Breaking changes

None.

Changelog

Not really player facing.

@github-actions github-actions Bot added S: Untriaged S: Needs Review This PR is awaiting reviews size/S C# UI FTL and removed S: Needs Review This PR is awaiting reviews S: Untriaged labels Aug 19, 2026
@Houtblokje

Copy link
Copy Markdown
Contributor

Not sure if it fits in this PR, but lemoon seed packets appear to also be lacking a localization string.

@Menshin

Menshin commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Not sure if it fits in this PR, but lemoon seed packets appear to also be lacking a localization string.

On it.

tech-disk-ui-total-label = There are {$amount} points on the selected server
tech-disk-ui-cost-label = Each disk costs {$amount} points to print
tech-disk-ui-print-button = Print Disk
tech-disk-ui-print-button = Print Disk for {$amount} points # Frontier: added $amount part

@Alkheemist Alkheemist Aug 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two things:

  • This style of commenting doesn't work for ftl files
Image
  • we don't need these FTL lines anyway as tech disk printers are disabled on frontier so you'd never see these

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darn, could have sworn it was working 👀
I'm leaving the lines in anyway, since the code is still present (or do you want me to comment it out ?)

Comment thread Resources/Locale/en-US/round-notifications/notifications.ftl Outdated
Comment thread Resources/Locale/en-US/components/screen-component.ftl Outdated
Comment thread Content.Server/_NF/Bank/StationATMSystem.cs
@Menshin

Menshin commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Requested changes made, thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing localizations

3 participants