Makes IoC compatible with the RT 277.0.0 [Dependency] source generator - #4811
Open
Menshin wants to merge 4 commits into
Open
Makes IoC compatible with the RT 277.0.0 [Dependency] source generator#4811Menshin wants to merge 4 commits into
Menshin wants to merge 4 commits into
Conversation
Content.Client classes to partial classes done.
github-actions
Bot
added
size/M
S: Untriaged
S: Needs Review
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
Bot
added
size/M
and removed
S: Merge Conflict
marlyn-x86
approved these changes
Aug 30, 2026
marlyn-x86
left a comment
marlyn-x86
left a comment
Contributor
There was a problem hiding this comment.
wow! that's a lot! well. from my cursory skimming, it looks ok...
github-actions
Bot
added
the
S: Merge Conflict
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Contributor
Author
|
To save me some time, i'll fix all merge conflicts when #4462 will be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
In prevision of the engine update i've removed the
readonlyattribute of[Dependency]and converted classes with[Dependency]topartialclasses for the whole Content part of the codebase.The
Robustpart of the codebase has already been updated in the engine update PR.This PR is basically a Frontier custom port of space-wizards/space-station-14#43863.
Requires #4462.
Why / Balance
In the version 277.0.0 of the RT engine, a source generator for
[Dependency]was added (space-wizards/RobustToolbox#6549) that requires[Dependency]to drop anyreadonlyattribute and the related classes to be declared aspartial.Also, to ensure people update their code, an analyzer has been added that issue warnings about these changes, but it warns these will eventually be considered as errors.
Without updating, the number of warnings will then surge when the RT engine update is merged.
Technical details
Regex-ed through
[Dependency]to remove thereadonlyattribute and double-checked while addingpartialto required classes (mostly by on and off elbow grease).If i ever missed some (given the size of the codebase, i'll be surprised none slipped through), they will be catched by the analyzer after the engine update and promptly taken care of.
How to test
After the engine update PR has been merged, compile and check no warning about
[Dependency]withreadonlyattribute or class missingpartialare issued.Requirements
Breaking changes
None, but obviously all new/ported code should followed the same pattern for
[Dependency]and related classes.Changelog
Code cleaning/updating, none needed,