Skip to content

Show market modifier on cargo pallet console - #4813

Open
isilkor wants to merge 2 commits into
new-frontiers-14:masterfrom
isilkor:cargo-console-bonus-display
Open

Show market modifier on cargo pallet console#4813
isilkor wants to merge 2 commits into
new-frontiers-14:masterfrom
isilkor:cargo-console-bonus-display

Conversation

@isilkor

@isilkor isilkor commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

About the PR

The cargo pallet console now displays the market modifier percentage it applies when selling items. If the appraisal value of the sold items is modified in any way, we'll also show a small amount of flavor text. The flavor text also mentions Nanotrasen on the console in the pirate cove because anything else would have been hard Nanotrasen also trades with pirates if they get goods at a discount that way. Capitalism, baby.

Why / Balance

Most cargo pallet consoles sold items for a value different from their appraisal value. TM sells at 125%, the cargo depots sell at 75%; only the NSF Wasp's cargo terminal actually paid exactly 100% market value. This is confusing for newbies most people because it's something that you only know about when you examine the console.

Technical details

Cloned upstream's CargoPalletMenu.xaml (and .cs) to the _NF namespace because it underwent significant modifications. We're now sending the market modifier and its effect on prices as a BUI state rather than just the amount of money the console will pay.
Also rolled back CargoPalletMenu.xaml.cs to its state on upstream because we're not using it anymore.

How to test

Load into NFDev. Spawn a lizard plushie on the cargo selling pallet (static value: 5 spesos). Check the appraisal value on all four cargo sale consoles. The expected values are (all values paid are rounded in favor of the market, i.e. fees are rounded up and bonuses are rounded down):

console modifier base fee/bonus total
ComputerPalletConsoleNFVeryLowMarket 50% fee $5 -$2.5 rounds to -$3 $2
ComputerPalletConsoleNFLowMarket 25% fee $5 -$1.25 rounds to -$2 $3
ComputerPalletConsoleNFNormalMarket 0% $5 $0 $5
ComputerPalletConsoleNFHighMarket 25% bonus $5 +$1.25 rounds to +$1 $6

Spawn a second lizard plushie. vv it and give it a server-side IgnoreMarketModifierComponent.
Check the appraisal values again. The expected values are, since one $5 plushie is affected by modifiers and one $5 plushie isn't:

console modifier base fee/bonus total
ComputerPalletConsoleNFVeryLowMarket 50% fee $10 -$3 $7
ComputerPalletConsoleNFLowMarket 25% fee $10 -$2 $8
ComputerPalletConsoleNFNormalMarket 0% $10 $0 $10
ComputerPalletConsoleNFHighMarket 25% bonus $10 +$1 $11

With the console window(s) kept open, vv the StaticPriceComponent on one of the plushies to a large (but reasonable) value. Click the "Appraise" button. Check that the displayed values do not get clipped but are displayed completely.

Media

most valuable lizard

Requirements

Breaking changes

None.

Changelog

🆑 Bonfire Lit

  • tweak: Cargo sale consoles now display a message in the UI when they pay other than market value.

We're no longer using this file, so we don't need to keep Frontier-
specific changes around.
@isilkor
isilkor marked this pull request as ready for review August 24, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant