Show market modifier on cargo pallet console - #4813
Open
isilkor wants to merge 2 commits into
Open
Conversation
We're no longer using this file, so we don't need to keep Frontier- specific changes around.
isilkor
marked this pull request as ready for review
August 24, 2026 18:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
The cargo pallet console now displays the market modifier percentage it applies when selling items. If the appraisal value of the sold items is modified in any way, we'll also show a small amount of flavor text. The flavor text also mentions Nanotrasen on the console in the pirate cove because
anything else would have been hardNanotrasen also trades with pirates if they get goods at a discount that way. Capitalism, baby.Why / Balance
Most cargo pallet consoles sold items for a value different from their appraisal value. TM sells at 125%, the cargo depots sell at 75%; only the NSF Wasp's cargo terminal actually paid exactly 100% market value. This is confusing for
newbiesmost people because it's something that you only know about when you examine the console.Technical details
Cloned upstream's CargoPalletMenu.xaml (and .cs) to the _NF namespace because it underwent significant modifications. We're now sending the market modifier and its effect on prices as a BUI state rather than just the amount of money the console will pay.
Also rolled back CargoPalletMenu.xaml.cs to its state on upstream because we're not using it anymore.
How to test
Load into NFDev. Spawn a lizard plushie on the cargo selling pallet (static value: 5 spesos). Check the appraisal value on all four cargo sale consoles. The expected values are (all values paid are rounded in favor of the market, i.e. fees are rounded up and bonuses are rounded down):
Spawn a second lizard plushie.
vvit and give it a server-sideIgnoreMarketModifierComponent.Check the appraisal values again. The expected values are, since one $5 plushie is affected by modifiers and one $5 plushie isn't:
With the console window(s) kept open,
vvtheStaticPriceComponenton one of the plushies to a large (but reasonable) value. Click the "Appraise" button. Check that the displayed values do not get clipped but are displayed completely.Media
Requirements
Breaking changes
None.
Changelog
🆑 Bonfire Lit