Partial AP - #4816
Open
BlueJoshHere wants to merge 5 commits into
Open
Conversation
* Partial AP. * Improvement. * Remove unused. * More improvements. * chore: Automatically update REUSE headers * chore: Automatically update REUSE headers * Improvements. * chore: Automatically update REUSE headers * chore: Automatically update REUSE headers * Remove armblade partial ap. * Penetration Tweaks. * chore: Automatically update REUSE headers --------- Co-authored-by: GoobBot <uristmchands@proton.me> Co-authored-by: gus <august.eymann@gmail.com> # Conflicts: # Content.Server/Projectiles/ProjectileSystem.cs # Content.Shared/Armor/SharedArmorSystem.cs # Content.Shared/Blocking/BlockingSystem.User.cs # Content.Shared/Clothing/SharedCursedMaskSystem.cs # Content.Shared/Damage/DamageModifierSet.cs # Content.Shared/Damage/DamageSpecifier.cs # Content.Shared/Damage/Systems/DamageProtectionBuffSystem.cs # Content.Shared/Damage/Systems/DamageableSystem.cs # Content.Shared/Projectiles/ProjectileComponent.cs # Content.Shared/Weapons/Melee/MeleeWeaponComponent.cs # Content.Shared/Weapons/Melee/SharedMeleeWeaponSystem.cs # Content.Shared/Weapons/Reflect/ReflectSystem.cs # Content.Shared/_Shitcode/Wizard/Spellblade/SharedSpellbladeSystem.cs # Content.Shared/_Shitmed/Body/Systems/SharedBodySystem.Targeting.cs # Resources/Locale/en-US/_Goobstation/store/uplink-catalog.ftl # Resources/Prototypes/Catalog/uplink_catalog.yml # Resources/Prototypes/Damage/modifier_sets.yml # Resources/Prototypes/Entities/Objects/Weapons/Guns/Ammunition/Projectiles/antimateriel.yml # Resources/Prototypes/Entities/Objects/Weapons/Guns/Ammunition/Projectiles/magnum.yml # Resources/Prototypes/Nyanotrasen/Damage/modifier_sets.yml # Resources/Prototypes/_DV/Damage/modifier_sets.yml # Resources/Prototypes/_EinsteinEngines/Damage/modifier_sets.yml # Resources/Prototypes/_Goobstation/Catalog/uplink_catalog.yml # Resources/Prototypes/_Goobstation/Changeling/Entities/Objects/Weapons/Melee/changeling_armblade.yml # Resources/Prototypes/_Goobstation/Damage/modifier_sets.yml # Resources/Prototypes/_Goobstation/Entities/Objects/Weapons/Guns/Ammunition/Projectiles/antimateriel.yml # Resources/Prototypes/_Goobstation/Entities/Objects/Weapons/Guns/Bow/hardlight_arrows.yml # Resources/Prototypes/_Goobstation/Entities/Objects/Weapons/Guns/Bow/hardlight_bow_protos.yml # Resources/Prototypes/_Goobstation/Entities/Objects/Weapons/Guns/Projectiles/projectiles.yml # Resources/Prototypes/_Goobstation/Heretic/Entities/Objects/Weapons/Melee/heretic_blades.yml # Resources/Prototypes/_Goobstation/Wizard/modifier_sets.yml # Resources/Prototypes/_Shitmed/Damage/modifier_sets.yml
github-actions
Bot
added
size/M
S: Needs Review
TheSecondLord
left a comment
TheSecondLord
left a comment
Contributor
There was a problem hiding this comment.
I think these are the only 2 upstream file modifications missing comments, rest look good.
Sounds very cool! Would definitely give revolvers a use. My initial reaction is 50% armor pierce on a crusher sounds quite strong, but I haven't experienced it so eh it's probably fine
blackknight954
approved these changes
Aug 29, 2026
blackknight954
left a comment
blackknight954
left a comment
Contributor
There was a problem hiding this comment.
Tested and it feels fine to me. Maybe down the line we can have this implemented on some other projectiles, but this works good now to make revolvers fill a niche.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Cherry Picks partial AP from Goob Goob-Station/Goob-Station#2299.
Added Partial AP to all .45 Ammo and to the Crusher and Glave.
Why / Balance
Revolvers are in a very bad spot currently. Giving them partial AP instead of the full AP gives them purpose again without completely invalidating Armor.
Gave the Crusher and Glave some Partial AP as they are most high skill ceiling melee weapons that hardly get used outside of minning. Making them a bit more valid against armored targets.
The Penetration values where tested against Culist UIV and Vroids.
As well as in PvP against NFSD exerimental armor.
The revolvers should be in a healthy spot as a sidearm without overshadowing longarms.
Technical details
How to test
Spawn in a .45 Revolver with any .45 ammo
Spawn a urist with any armor.
Shoot them and check the damage. (Damage will partly penetrate the armor)
Spawn a Crusher or Glaive
Spawn a urist with any armor.
Hit them and check the damage. (Damage will again partly penetrate the armor)
Media
Difficult to show Partial AP in media
Requirements
Breaking changes
Changelog
🆑