CachedResources for GasTileDangerousTemperatureOverlay (#43032) - #4825
Open
blackknight954 wants to merge 2 commits into
Open
CachedResources for GasTileDangerousTemperatureOverlay (#43032)#4825blackknight954 wants to merge 2 commits into
blackknight954 wants to merge 2 commits into
Conversation
* init * minifix * that is nullable --------- Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
github-actions
Bot
added
S: Untriaged
size/S
S: Needs Review
Contributor
|
|
Many newer overlays use IRenderTextures that are sized to the rendered viewport. This was completely broken, because a single viewport can be rendered on multiple viewports in a single frame. The end result of this was that in the better case, constant render targets were allocated and freed, which is extremely inefficient. In the worse case, many of these overlays completely failed to Dispose() their render targets, leading to *extremely* swift VRAM OOMs. This fixes all the overlays to properly cache resources per viewport. This uses new engine functionality, so it requires engine master. This is still a pretty lousy way to do GPU resource management but, well, anything better needs a render graph, so...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Cherrypicks 43032 from upstream, fixes a performance issue for opticalthermal temperature shaders that causes performance degredation.
Why / Balance
The more performance the better.
Technical details
See original PR for media and technical details
Requirements
Non-player-facing changes do not need changelogs as far as I am aware, but feel free to correct if I am wrong.