Skip to content

fix: output monitor input names instead of codes if we have them - #408

Merged
newAM merged 8 commits into
newAM:mainfrom
danudey:fixup-outputs-and-typos
Oct 21, 2025
Merged

newAM merged 8 commits into
newAM:mainfrom
danudey:fixup-outputs-and-typos

Conversation

@danudey

@danudey danudey commented Oct 16, 2025

Copy link
Copy Markdown
Contributor

Simple PR; if we have a name for the MonitorInput, print it; otherwise, print "UNKNOWN" with the monitor code.

Also added some minor cleanups:

  • Replace sys.stdout.write with print (since I couldn't see any indication of whether there was a necessity to use sys.stdout.write specifically)
  • Fix a typo

@newAM newAM left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the slow review, I'm on the road a lot for work, it may take a couple weeks before I get to the others you opened.

@newAM
newAM merged commit 14b7881 into newAM:main Oct 21, 2025
16 checks passed
@danudey
danudey deleted the fixup-outputs-and-typos branch October 21, 2025 19:50
@danudey

danudey commented Oct 21, 2025

Copy link
Copy Markdown
Contributor Author

Thanks! Sorry for the slow review, I'm on the road a lot for work, it may take a couple weeks before I get to the others you opened.

No apologies necessary! I'm used to these kinds of projects being completely abandoned so I'm just happy that I can contribute to this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants