fix: WordPress 6.8+ compatibility and iframe editor support #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onent. Remove deprecated addWonderBlocksButton function and streamline toolbar button rendering logic.
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the WonderBlocks plugin for WordPress 6.8+ compatibility and adds support for the iframe editor introduced in WordPress 6.3, addressing deprecation warnings and fixing critical compatibility issues.
- Updated WordPress component props to use new standardized sizes and spacing (
__next40pxDefaultSize,__nextHasNoMarginBottom) - Fixed block category registration order and CSS loading for iframe editor compatibility
- Refactored toolbar button logic into a dedicated component with improved iframe handling
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/wonder-blocks.js |
Reordered imports to register block category before blocks; refactored toolbar button to use new component; removed unused constants |
src/components/Modal/Sidebar/Categories.jsx |
Added __next40pxDefaultSize prop to SelectControl for WordPress 6.8+ compatibility |
src/components/Modal/Modal.jsx |
Updated data store selector from deprecated core/edit-site to core/editor |
src/components/Modal/Content/KeywordFilter.jsx |
Added __nextHasNoMarginBottom prop to SearchControl for updated margin behavior |
src/components/AddToolbarButton.jsx |
New component handling toolbar button addition with iframe editor support and retry logic |
src/blocks/inspector-control.js |
Added __next40pxDefaultSize to SelectControl instances; removed deprecated theme color UI |
src/blocks/block.json |
Updated apiVersion to 3 for iframe compatibility; added style field for CSS loading |
includes/Library/Admin.php |
Changed hook from enqueue_block_editor_assets to enqueue_block_assets; added validation and duplicate registration checks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR updates the WonderBlocks plugin to be compatible with WordPress 6.8+ and ensures full support for the iframe editor introduced in WordPress 6.3. It addresses multiple deprecation warnings and fixes compatibility issues.
Changes
Deprecation Fixes
SelectControl: Added
__next40pxDefaultSizeprop to allSelectControlinstances to opt into the new 40px default size (replaces deprecated 36px)SearchControl: Added
__nextHasNoMarginBottomprop to opt into new margin stylesBlock API: Updated block
apiVersionfrom 2 to 3 for iframe editor compatibilityData Store: Replaced deprecated
select('core/edit-site').getEditedPostType()withselect('core/editor').getCurrentPostType()Iframe Editor Compatibility
Block Category Registration: Fixed import order to register category before block registration
register-categoryimport beforeblockimport inwonder-blocks.jsCSS Enqueuing: Fixed CSS loading for iframe editor
enqueue_block_assetshook inAdmin.phpto ensure styles load in both parent and iframestylefield toblock.jsonreferencing the registered style handleType of Change
Production
Development
Visual
Checklist
Further comments