Skip to content

update .pot file and review spanish translations #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2025
Merged

Conversation

crodriguezbrito
Copy link
Contributor

Proposed changes

The following PR will update the .pot file and fix some strings for the Spanish version #PRESS10-194

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube
Copy link
Member

@crodriguezbrito we did a lot of translation work on this today, might be best to restart from main as this will have a mind-numbering merge conflict now.

@crodriguezbrito
Copy link
Contributor Author

Hello @circlecube
I fixed the merge conflicts and I updated the es_ES translation.
When you have time, could you check it?

@arunshenoy99 arunshenoy99 merged commit 114f5d8 into main Apr 28, 2025
2 of 7 checks passed
@arunshenoy99 arunshenoy99 deleted the PRESS10-194 branch April 28, 2025 11:39
@circlecube
Copy link
Member

Noticed in the latest plugin release that there are some missing translations for performance app. Which brought be looking at this PR again. I'm seeing that it removed quite a few translations. Can we get these brought back somehow? It may take some manual updates in the PO files, and then let the i18n command update the PHP and json language files.

@arunshenoy99 & @crodriguezbrito cc @wpscholar

@circlecube circlecube restored the PRESS10-194 branch April 30, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants