Skip to content

Fix translations #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Apr 25, 2025
Merged

Fix translations #174

merged 33 commits into from
Apr 25, 2025

Conversation

wpscholar
Copy link
Member

@wpscholar wpscholar commented Apr 25, 2025

Proposed changes

Fix issues where translations weren't generating properly.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update/refactoring
  • Documentation Update

Image

Cursor_and_Rendimiento___My_Website_—_WordPress

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@wpscholar wpscholar requested a review from a team April 25, 2025 18:56
@wpscholar wpscholar self-assigned this Apr 25, 2025
@Copilot Copilot AI review requested due to automatic review settings April 25, 2025 18:56
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to fix issues with translation generation by updating related code assets.

  • Updated the license text for the minified performance script to ensure proper attribution.
Files not reviewed (19)
  • .nvmrc: Language not supported
  • build/performance/performance.min.asset.php: Language not supported
  • composer.json: Language not supported
  • includes/Services/I18nService.php: Language not supported
  • languages/wp-module-performance-de_DE-nfd-performance-bulk-optimizer.json: Language not supported
  • languages/wp-module-performance-de_DE-nfd-performance-optimizer-marker.json: Language not supported
  • languages/wp-module-performance-de_DE-nfd-performance.json: Language not supported
  • languages/wp-module-performance-de_DE.l10n.php: Language not supported
  • languages/wp-module-performance-en_AU-nfd-performance-bulk-optimizer.json: Language not supported
  • languages/wp-module-performance-en_AU-nfd-performance-optimizer-marker.json: Language not supported
  • languages/wp-module-performance-en_AU-nfd-performance.json: Language not supported
  • languages/wp-module-performance-en_AU.l10n.php: Language not supported
  • languages/wp-module-performance-en_GB-nfd-performance-bulk-optimizer.json: Language not supported
  • languages/wp-module-performance-en_GB-nfd-performance-optimizer-marker.json: Language not supported
  • languages/wp-module-performance-en_GB-nfd-performance.json: Language not supported
  • languages/wp-module-performance-en_GB.l10n.php: Language not supported
  • languages/wp-module-performance-es_ES-nfd-performance-bulk-optimizer.json: Language not supported
  • languages/wp-module-performance-es_ES-nfd-performance-optimizer-marker.json: Language not supported
  • languages/wp-module-performance-es_ES-nfd-performance.json: Language not supported

circlecube
circlecube previously approved these changes Apr 25, 2025
@circlecube
Copy link
Member

The bluehost test failures are unrelated to this module, and the other plugins will need updating since the module-based components they were deep linking to are no longer present those build fails. We'll have to update the plugins over time to get the performance page removed from the plugin app so the build can run and tests can perform.

@circlecube circlecube merged commit b4bdaaa into main Apr 25, 2025
6 of 7 checks passed
@circlecube circlecube deleted the fix/translations branch April 25, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants