Skip to content

Conversation

mcrosson
Copy link

@mcrosson mcrosson commented Sep 5, 2025

Since I was digging around the code for #359 , and #360 I figured I'd make an attempt to get the app updated to API 35 which is the most recent NDK toolchain version available. Updates to address the 16kb page size requirement are also included.

This is an incredibly rough update and not fully vetted or tested. It also includes the changes from both #359 and #360.

Of note: the biggest issue on update was the UI being blocked by the status bar and action bar. Addressing this is the bulk of the code changes.

@ITron-Legends
Copy link

ITron-Legends commented Sep 6, 2025

I do want to note I tested this app on the rclone version 1.17.1 and go version 1.25.1
Everything seems to work fine.

I'd appreciate it if you could make code changes for the log file as well, android no longer gives you permissions to access app data folders.

@mcrosson
Copy link
Author

mcrosson commented Sep 6, 2025

Note: I'm not the maintainer of Round Sync, just another human who poked at the code recently and wanted to contribute back.

rclone version 1.17.1

It looks like I had a typo in my commit message. I updated the code to the most recent release on the rclone download page, I actually used 1.71.0 as the rclone release version update. I checked the rclone download page and it looks like 1.71.0 is the most recent version that's been released.

go version 1.25.1

Given rclone builds with older versions of go and the go binaries have to be installed separate, I didn't feel the need to bump the go release version in the project (ie. no forced upgrades). My local environment is using 1.25.1 as well.

I'd appreciate it if you could make code changes for the log file as well, android no longer gives you permissions to access app data folders.

I ended up looking at the code for Round Sync to troubleshoot an error I was getting that would have been exposed via logging. The expose all rclone errors as logs in the main app ui change that's part of this pull request is meant to address this need. If you turn on the logging option in the settings rclone errors/warnings will be added to the 'logs' area of the app. If you'd like to see the changes in isolation, #360 has the same changes as a dedicated PR.

Note: I didn't see a way to delete logs via the UI so I left this part of my changes as 'off by default'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants