Skip to content

Test for - Executing integrity tests as a CI job#12021

Closed
adidner wants to merge 1 commit intocontent-repofrom
15883-executing-cms-validations-as-ci-job-in-gha
Closed

Test for - Executing integrity tests as a CI job#12021
adidner wants to merge 1 commit intocontent-repofrom
15883-executing-cms-validations-as-ci-job-in-gha

Conversation

@adidner
Copy link
Contributor

@adidner adidner commented Dec 23, 2025

Description

I will end up merging this into the main repo not content but this is the code I will merge.

We wanted to update our scripts for integrity tests to run via github actions rather than an AWS lamda. This is nice because the action will only run every time a PR is made against the content-repo by content rather than running every hour or so, saving cost and tightening the feedback loops between issue and resolution.

I incorporated the work with AWS SNS and slack notifications after realizing emails from Github Actions aren't super intuitive to a non-technical person.

Ticket

This pull request resolves #15883.

Approach

Steps to Test

You can see the github action having run here https://github.com/newjersey/navigator.business.nj.gov/actions/runs/20493056734/job/58888526832?pr=12021

You can see specifically that it failed and it failed on a number of things that are valid.

You can also see slack messages in the bizx-alerts-cms channel corresponding to the errors described here.

Notes

I'm not sure I want to merge this yet because there are valid follow up errors for regina to resolve. If they aren't resolved the issues will rightly appear every time a content person tries to make a change.

Code author checklist

  • I have rebased this branch from the latest main branch
  • I have performed a self-review of my code
  • My code follows the style guide
  • I have created and/or updated relevant documentation on the engineering documentation website
  • I have not used any relative imports
  • I have pruned any instances of unused code
  • I have not added any markdown to labels, titles and button text in config
  • If I added/updated any values in userData (including profileData, formationData etc), then I added a new migration file
  • I have checked for and removed instances of unused config from CMS
  • If I added any new collections to the CMS config, then I updated the search tool and cmsCollections.ts (see CMS Additions in Engineering Reference/FAQ on the engineering documentation site)
  • I have updated relevant .env values in both .env-template and in Bitwarden

@adidner adidner force-pushed the 15883-executing-cms-validations-as-ci-job-in-gha branch 13 times, most recently from ac410e9 to 4e69b17 Compare December 29, 2025 21:32
Comment on lines 23 to 25
node-version: 22.20.0
cache: yarn

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've made some changes to the approach on directly referencing the node-version.

this should now be

Suggested change
node-version: 22.20.0
cache: yarn
- name: Setup Node.js
uses: actions/setup-node@v6
with:
node-version-file: .nvmrc
cache: yarn

@adidner adidner force-pushed the 15883-executing-cms-validations-as-ci-job-in-gha branch 2 times, most recently from 72c54b9 to bed7799 Compare January 20, 2026 21:29
@adidner adidner force-pushed the 15883-executing-cms-validations-as-ci-job-in-gha branch from bed7799 to bb68632 Compare January 21, 2026 21:29
@adidner adidner closed this Jan 21, 2026
@adidner adidner deleted the 15883-executing-cms-validations-as-ci-job-in-gha branch January 21, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants