Test for - Executing integrity tests as a CI job#12021
Closed
adidner wants to merge 1 commit intocontent-repofrom
Closed
Test for - Executing integrity tests as a CI job#12021adidner wants to merge 1 commit intocontent-repofrom
adidner wants to merge 1 commit intocontent-repofrom
Conversation
ac410e9 to
4e69b17
Compare
Comment on lines
23
to
25
| node-version: 22.20.0 | ||
| cache: yarn | ||
|
|
Contributor
There was a problem hiding this comment.
We've made some changes to the approach on directly referencing the node-version.
this should now be
Suggested change
| node-version: 22.20.0 | |
| cache: yarn | |
| - name: Setup Node.js | |
| uses: actions/setup-node@v6 | |
| with: | |
| node-version-file: .nvmrc | |
| cache: yarn | |
72c54b9 to
bed7799
Compare
bed7799 to
bb68632
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I will end up merging this into the main repo not content but this is the code I will merge.
We wanted to update our scripts for integrity tests to run via github actions rather than an AWS lamda. This is nice because the action will only run every time a PR is made against the content-repo by content rather than running every hour or so, saving cost and tightening the feedback loops between issue and resolution.
I incorporated the work with AWS SNS and slack notifications after realizing emails from Github Actions aren't super intuitive to a non-technical person.
Ticket
This pull request resolves #15883.
Approach
Steps to Test
You can see the github action having run here https://github.com/newjersey/navigator.business.nj.gov/actions/runs/20493056734/job/58888526832?pr=12021
You can see specifically that it failed and it failed on a number of things that are valid.
You can also see slack messages in the bizx-alerts-cms channel corresponding to the errors described here.
Notes
I'm not sure I want to merge this yet because there are valid follow up errors for regina to resolve. If they aren't resolved the issues will rightly appear every time a content person tries to make a change.
Code author checklist
userData(includingprofileData,formationDataetc), then I added a new migration filecmsCollections.ts(see CMS Additions in Engineering Reference/FAQ on the engineering documentation site).envvalues in both.env-templateand in Bitwarden